Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9742)

Unified Diff: chrome/common/render_messages.cc

Issue 6713084: Move the rest of the renderer->browser messages that belong in content. Also do a bunch of cleanup: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/common/render_messages_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/render_messages.cc
===================================================================
--- chrome/common/render_messages.cc (revision 79188)
+++ chrome/common/render_messages.cc (working copy)
@@ -2,38 +2,29 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Get basic type definitions.
-#define IPC_MESSAGE_IMPL
#include "chrome/common/render_messages.h"
-#include "chrome/common/common_param_traits.h"
-// Generate constructors.
-#include "ipc/struct_constructor_macros.h"
-#include "chrome/common/render_messages.h"
-
-// Generate destructors.
-#include "ipc/struct_destructor_macros.h"
-#include "chrome/common/render_messages.h"
-
-// Generate param traits write methods.
-#include "ipc/param_traits_write_macros.h"
namespace IPC {
-#include "chrome/common/render_messages.h"
-} // namespace IPC
-// Generate param traits read methods.
-#include "ipc/param_traits_read_macros.h"
-namespace IPC {
-#include "chrome/common/render_messages.h"
-} // namespace IPC
+void ParamTraits<ContentSettings>::Write(
+ Message* m, const ContentSettings& settings) {
+ for (size_t i = 0; i < arraysize(settings.settings); ++i)
+ WriteParam(m, settings.settings[i]);
+}
-// Generate param traits log methods.
-#include "ipc/param_traits_log_macros.h"
-namespace IPC {
-#include "chrome/common/render_messages.h"
-} // namespace IPC
+bool ParamTraits<ContentSettings>::Read(
+ const Message* m, void** iter, ContentSettings* r) {
+ for (size_t i = 0; i < arraysize(r->settings); ++i) {
+ if (!ReadParam(m, iter, &r->settings[i]))
+ return false;
+ }
+ return true;
+}
-namespace IPC {
+void ParamTraits<ContentSettings>::Log(
+ const ContentSettings& p, std::string* l) {
+ l->append("<ContentSettings>");
+}
void ParamTraits<URLPattern>::Write(Message* m, const param_type& p) {
WriteParam(m, p.valid_schemes());
@@ -77,67 +68,4 @@
LogParam(p.patterns(), l);
}
-void ParamTraits<webkit_glue::WebAccessibility>::Write(Message* m,
- const param_type& p) {
- WriteParam(m, p.id);
- WriteParam(m, p.name);
- WriteParam(m, p.value);
- WriteParam(m, static_cast<int>(p.role));
- WriteParam(m, static_cast<int>(p.state));
- WriteParam(m, p.location);
- WriteParam(m, p.attributes);
- WriteParam(m, p.children);
- WriteParam(m, p.indirect_child_ids);
- WriteParam(m, p.html_attributes);
-}
-
-bool ParamTraits<webkit_glue::WebAccessibility>::Read(
- const Message* m, void** iter, param_type* p) {
- bool ret = ReadParam(m, iter, &p->id);
- ret = ret && ReadParam(m, iter, &p->name);
- ret = ret && ReadParam(m, iter, &p->value);
- int role = -1;
- ret = ret && ReadParam(m, iter, &role);
- if (role >= webkit_glue::WebAccessibility::ROLE_NONE &&
- role < webkit_glue::WebAccessibility::NUM_ROLES) {
- p->role = static_cast<webkit_glue::WebAccessibility::Role>(role);
- } else {
- p->role = webkit_glue::WebAccessibility::ROLE_NONE;
- }
- int state = 0;
- ret = ret && ReadParam(m, iter, &state);
- p->state = static_cast<webkit_glue::WebAccessibility::State>(state);
- ret = ret && ReadParam(m, iter, &p->location);
- ret = ret && ReadParam(m, iter, &p->attributes);
- ret = ret && ReadParam(m, iter, &p->children);
- ret = ret && ReadParam(m, iter, &p->indirect_child_ids);
- ret = ret && ReadParam(m, iter, &p->html_attributes);
- return ret;
-}
-
-void ParamTraits<webkit_glue::WebAccessibility>::Log(const param_type& p,
- std::string* l) {
- l->append("(");
- LogParam(p.id, l);
- l->append(", ");
- LogParam(p.name, l);
- l->append(", ");
- LogParam(p.value, l);
- l->append(", ");
- LogParam(static_cast<int>(p.role), l);
- l->append(", ");
- LogParam(static_cast<int>(p.state), l);
- l->append(", ");
- LogParam(p.location, l);
- l->append(", ");
- LogParam(p.attributes, l);
- l->append(", ");
- LogParam(p.children, l);
- l->append(", ");
- LogParam(p.html_attributes, l);
- l->append(", ");
- LogParam(p.indirect_child_ids, l);
- l->append(")");
-}
-
} // namespace IPC
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/common/render_messages_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698