Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: chrome/common/render_messages_params.cc

Issue 6713084: Move the rest of the renderer->browser messages that belong in content. Also do a bunch of cleanup: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/render_messages_params.h ('k') | chrome/common/render_messages_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/render_messages_params.cc
===================================================================
--- chrome/common/render_messages_params.cc (revision 79188)
+++ chrome/common/render_messages_params.cc (working copy)
@@ -4,7 +4,6 @@
#include "chrome/common/render_messages_params.h"
-#include "chrome/common/common_param_traits.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/render_messages.h"
#include "net/base/upload_data.h"
@@ -130,18 +129,6 @@
ViewHostMsg_DomMessage_Params::~ViewHostMsg_DomMessage_Params() {
}
-ViewHostMsg_MalwareDOMDetails_Node::ViewHostMsg_MalwareDOMDetails_Node() {
-}
-
-ViewHostMsg_MalwareDOMDetails_Node::~ViewHostMsg_MalwareDOMDetails_Node() {
-}
-
-ViewHostMsg_MalwareDOMDetails_Params::ViewHostMsg_MalwareDOMDetails_Params() {
-}
-
-ViewHostMsg_MalwareDOMDetails_Params::~ViewHostMsg_MalwareDOMDetails_Params() {
-}
-
ViewMsg_ExtensionLoaded_Params::ViewMsg_ExtensionLoaded_Params()
: location(Extension::INVALID) {
}
@@ -224,30 +211,6 @@
}
};
-template <>
-struct ParamTraits
- <ViewHostMsg_AccessibilityNotification_Params::NotificationType> {
- typedef ViewHostMsg_AccessibilityNotification_Params params;
- typedef params::NotificationType param_type;
- static void Write(Message* m, const param_type& p) {
- int val = static_cast<int>(p);
- WriteParam(m, val);
- }
- static bool Read(const Message* m, void** iter, param_type* p) {
- int val = 0;
- if (!ReadParam(m, iter, &val) ||
- val < params::NOTIFICATION_TYPE_CHECK_STATE_CHANGED ||
- val > params::NOTIFICATION_TYPE_SELECTED_TEXT_CHANGED) {
- return false;
- }
- *p = static_cast<param_type>(val);
- return true;
- }
- static void Log(const param_type& p, std::string* l) {
- ParamTraits<int>::Log(static_cast<int>(p), l);
- }
-};
-
void ParamTraits<ViewHostMsg_PageHasOSDD_Type>::Write(Message* m,
const param_type& p) {
m->WriteInt(p.type);
@@ -572,85 +535,4 @@
l->append(")");
}
-void ParamTraits<ViewHostMsg_AccessibilityNotification_Params>::Write(
- Message* m,
- const param_type& p) {
- WriteParam(m, p.notification_type);
- WriteParam(m, p.acc_obj);
-}
-
-bool ParamTraits<ViewHostMsg_AccessibilityNotification_Params>::Read(
- const Message* m,
- void** iter,
- param_type* p) {
- return
- ReadParam(m, iter, &p->notification_type) &&
- ReadParam(m, iter, &p->acc_obj);
-}
-
-void ParamTraits<ViewHostMsg_AccessibilityNotification_Params>::Log(
- const param_type& p,
- std::string* l) {
- l->append("(");
- LogParam(p.notification_type, l);
- l->append(", ");
- LogParam(p.acc_obj, l);
- l->append(")");
-}
-
-void ParamTraits<ViewHostMsg_MalwareDOMDetails_Params>::Write(
- Message* m,
- const param_type& p) {
- WriteParam(m, p.nodes);
-}
-
-bool ParamTraits<ViewHostMsg_MalwareDOMDetails_Params>::Read(
- const Message* m,
- void** iter,
- param_type* p) {
- return ReadParam(m, iter, &p->nodes);
-}
-
-void ParamTraits<ViewHostMsg_MalwareDOMDetails_Params>::Log(
- const param_type& p,
- std::string* l) {
- l->append("(");
- LogParam(p.nodes, l);
- l->append(")");
-}
-
-void ParamTraits<ViewHostMsg_MalwareDOMDetails_Node>::Write(
- Message* m,
- const param_type& p) {
- WriteParam(m, p.url);
- WriteParam(m, p.tag_name);
- WriteParam(m, p.parent);
- WriteParam(m, p.children);
-}
-
-bool ParamTraits<ViewHostMsg_MalwareDOMDetails_Node>::Read(
- const Message* m,
- void** iter,
- param_type* p) {
- return
- ReadParam(m, iter, &p->url) &&
- ReadParam(m, iter, &p->tag_name) &&
- ReadParam(m, iter, &p->parent) &&
- ReadParam(m, iter, &p->children);
-}
-
-void ParamTraits<ViewHostMsg_MalwareDOMDetails_Node>::Log(
- const param_type& p,
- std::string* l) {
- l->append("(");
- LogParam(p.url, l);
- l->append(", ");
- LogParam(p.tag_name, l);
- l->append(", ");
- LogParam(p.parent, l);
- l->append(", ");
- LogParam(p.children, l);
- l->append(")");
-}
-
} // namespace IPC
« no previous file with comments | « chrome/common/render_messages_params.h ('k') | chrome/common/render_messages_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698