Issue 6712050: Revert 78801 - Addition of GL-redirecting mechanism for the Skia/GPU back-end. During execution o...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6712050: Revert 78801 - Addition of GL-redirecting mechanism for the Skia/GPU back-end. During execution o... (Closed)

Created:
9 years, 9 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
twiz, Jeff Timanus

CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 78801 - Addition of GL-redirecting mechanism for the Skia/GPU back-end. During execution of the layout tests (DumpRenderTree), all GL-calls are invoked via Mesa. A GL re-direction mechanism was added to skia in revision (http://code.google.com/p/skia/source/detail?r=937) These changes populate the skia re-direction interface with the gl implementation currently in use in Chrome: The app\gfx\gl bindings. R=kbr, bsalomon Review URL: http://codereview.chromium.org/6677105 TBR=twiz@chromium.org R=* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78808

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -555 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/app_base.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	app/gfx/gl/generate_bindings.py	View	3 chunks	+1 line, -3 lines	0 comments	Download
D	app/gfx/gl/gl_bindings_skia.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	app/gfx/gl/gl_bindings_skia.cc	View	1 chunk	+0 lines, -517 lines	0 comments	Download
M	app/gfx/gl/gl_interface.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/common/gl_mock.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	skia/skia.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/support/test_webkit_client.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM.

Thanks for taking care of this, Bradley.