Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 6677105: Redirect Skia/Ganesh GL calls to Mesa during the layout tests. (Closed)

Created:
9 years, 9 months ago by Jeff Timanus
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, greggman
Visibility:
Public.

Description

Addition of GL-redirecting mechanism for the Skia/GPU back-end. During execution of the layout tests (DumpRenderTree), all GL-calls are invoked via Mesa. A GL re-direction mechanism was added to skia in revision (http://code.google.com/p/skia/source/detail?r=937) These changes populate the skia re-direction interface with the gl implementation currently in use in Chrome: The app\gfx\gl bindings. R=kbr, bsalomon Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78801 Reverted: http://codereview.chromium.org/6712050/

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : Add logging include. #

Patch Set 5 : Add GL mock functions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -2 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M app/app_base.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/gfx/gl/generate_bindings.py View 1 2 3 4 3 chunks +3 lines, -1 line 0 comments Download
A app/gfx/gl/gl_bindings_skia.h View 1 chunk +21 lines, -0 lines 0 comments Download
A app/gfx/gl/gl_bindings_skia.cc View 1 2 3 1 chunk +517 lines, -0 lines 0 comments Download
M app/gfx/gl/gl_interface.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gl_mock.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M skia/skia.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/test_webkit_client.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jeff Timanus
PTAL. Any advice on how to provide a GLES 2.0 emulation layer on Mesa, or ...
9 years, 9 months ago (2011-03-17 04:40:55 UTC) #1
bsalomon
LGTM. It seems like this gets us almost all the way to getting the cmd ...
9 years, 9 months ago (2011-03-17 13:38:52 UTC) #2
Ken Russell (switch to Gerrit)
9 years, 9 months ago (2011-03-17 21:06:52 UTC) #3
LGTM

The closest thing we have to a vanilla GLES2 header is in
src/third_party/angle/include/GLES2/gl2.h .

If what you want is the enums and typedefs for the function pointers, we could
probably generate such a header file pretty easily using the script
src/gpu/command_buffer/build_gles2_cmd_buffer.py .

Powered by Google App Engine
This is Rietveld 408576698