Fixed a few styles issues in skia::PlatformDevice. Made function names consistent. Added Begin/En...

Fixed a few styles issues in skia::PlatformDevice. Made function names consistent. Added Begin/EndPlatformPaint on Mac.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80707

[alokp, 2011-04-05 19:46:47]

Split off from http://codereview.chromium.org/6783023 to make it manageable.

[vandebo (ex-Chrome), 2011-04-05 20:38:49]

http://codereview.chromium.org/6691067/diff/1024/skia/ext/platform_device_mac.h
File skia/ext/platform_device_mac.h (right):

http://codereview.chromium.org/6691067/diff/1024/skia/ext/platform_device_mac...
skia/ext/platform_device_mac.h:31: virtual CGContextRef GetBitmapContext() = 0;
Is there a reason to keep this method in addition to BeginPlatformPaint?

http://codereview.chromium.org/6691067/diff/1024/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/6691067/diff/1024/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1343: HDC dc =
canvas->beginPlatformPaint();
*B*eginPlatformPaint

[alokp, 2011-04-05 20:49:29]

http://codereview.chromium.org/6691067/diff/1024/skia/ext/platform_device_mac.h
File skia/ext/platform_device_mac.h (right):

http://codereview.chromium.org/6691067/diff/1024/skia/ext/platform_device_mac...
skia/ext/platform_device_mac.h:31: virtual CGContextRef GetBitmapContext() = 0;
On 2011/04/05 20:38:49, vandebo wrote:
> Is there a reason to keep this method in addition to BeginPlatformPaint?

No. I will eventually delete it when I get a mac.

http://codereview.chromium.org/6691067/diff/1024/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/6691067/diff/1024/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1343: HDC dc =
canvas->beginPlatformPaint();
On 2011/04/05 20:38:49, vandebo wrote:
> *B*eginPlatformPaint

This is a call on canvas, not device. I am not fixing canvas in this CL. Canvas
will be deprecated soon.

[vandebo (ex-Chrome), 2011-04-05 20:59:09]

Wouldn't hurt to see green try bots, but LGTM.

http://codereview.chromium.org/6691067/diff/1024/skia/ext/platform_device_mac.h
File skia/ext/platform_device_mac.h (right):

http://codereview.chromium.org/6691067/diff/1024/skia/ext/platform_device_mac...
skia/ext/platform_device_mac.h:31: virtual CGContextRef GetBitmapContext() = 0;
On 2011/04/05 20:49:29, Alok Priyadarshi wrote:
> On 2011/04/05 20:38:49, vandebo wrote:
> > Is there a reason to keep this method in addition to BeginPlatformPaint?
> 
> No. I will eventually delete it when I get a mac.

You could probably manage this using a couple rounds of try bots while doing
other things, but it can wait if you like.

http://codereview.chromium.org/6691067/diff/1024/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/6691067/diff/1024/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:1343: HDC dc =
canvas->beginPlatformPaint();
On 2011/04/05 20:49:29, Alok Priyadarshi wrote:
> On 2011/04/05 20:38:49, vandebo wrote:
> > *B*eginPlatformPaint
> 
> This is a call on canvas, not device. I am not fixing canvas in this CL.
Canvas
> will be deprecated soon.

Oops, right.

[alokp, 2011-04-05 21:03:51]

On 2011/04/05 20:59:09, vandebo wrote:
> Wouldn't hurt to see green try bots, but LGTM.
> 

I am waiting for the trybots to pick your CL. Otherwise my CL will not merge.

[vandebo (ex-Chrome), 2011-04-05 21:04:50]

you can try with the -r arg to specify a revision.

On Tue, Apr 5, 2011 at 2:03 PM, <alokp@chromium.org> wrote:

> On 2011/04/05 20:59:09, vandebo wrote:
>
>> Wouldn't hurt to see green try bots, but LGTM.
>>
>
>
> I am waiting for the trybots to pick your CL. Otherwise my CL will not
> merge.
>
>
> http://codereview.chromium.org/6691067/
>

[alokp, 2011-04-06 14:53:09]

Adding OWNERS.

[darin (slow to review), 2011-04-06 20:54:10]

LGTM