Fixed a few styles issues in skia::PlatformDevice. Made function names consistent. Added Begin/En...

skia/ext/platform_device_mac.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SKIA_EXT_PLATFORM_DEVICE_MAC_H_
 #define SKIA_EXT_PLATFORM_DEVICE_MAC_H_
 #pragma once
 
 #import <ApplicationServices/ApplicationServices.h>
 #include "third_party/skia/include/core/SkDevice.h"
@@ skipping 10 matching lines @@
 // functions.
 // This class is abstract and must be subclassed. It provides the basic
 // interface to implement it either with or without a bitmap backend.
 class PlatformDevice : public SkDevice {
  public:
   typedef CGContextRef PlatformSurface;
 
   // The CGContext that corresponds to the bitmap, used for CoreGraphics
   // operations drawing into the bitmap. This is possibly heavyweight, so it
   // should exist only during one pass of rendering.
   virtual CGContextRef GetBitmapContext() = 0;

[vandebo (ex-Chrome), 2011/04/05 20:38:49]

Is there a reason to keep this method in addition to BeginPlatformPaint?

[alokp, 2011/04/05 20:49:29]

No. I will eventually delete it when I get a mac.

[vandebo (ex-Chrome), 2011/04/05 20:59:09]

You could probably manage this using a couple rounds of try bots while doing
other things, but it can wait if you like.

 
   // Draws to the given graphics context. If the bitmap context doesn't exist,
   // this will temporarily create it. However, if you have created the bitmap
   // context, it will be more efficient if you don't free it until after this
   // call so it doesn't have to be created twice.  If src_rect is null, then
   // the entirety of the source device will be copied.
   virtual void DrawToContext(CGContextRef context, int x, int y,
                              const CGRect* src_rect) = 0;
 
   // Returns if the preferred rendering engine is vectorial or bitmap based.
   virtual bool IsVectorial() = 0;
 
   // Returns if native platform APIs are allowed to render text to this device.
   virtual bool IsNativeFontRenderingAllowed();
 
+  virtual PlatformSurface BeginPlatformPaint();
+  virtual void EndPlatformPaint();
+
   // Initializes the default settings and colors in a device context.
   static void InitializeCGContext(CGContextRef context);
 
   // Loads a SkPath into the CG context. The path can there after be used for
   // clipping or as a stroke.
   static void LoadPathToCGContext(CGContextRef context, const SkPath& path);
 
   // Loads a SkRegion into the CG context.
   static void LoadClippingRegionToCGContext(CGContextRef context,
                                             const SkRegion& region,
                                             const SkMatrix& transformation);
 
  protected:
   // Forwards |bitmap| to SkDevice's constructor.
   PlatformDevice(const SkBitmap& bitmap);
 
   // Loads the specified Skia transform into the device context
   static void LoadTransformToCGContext(CGContextRef context,
                                        const SkMatrix& matrix);
 };
 
 }  // namespace skia
 
 #endif  // SKIA_EXT_PLATFORM_DEVICE_MAC_H_