Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5758)

Unified Diff: chrome_frame/test/perf/chrome_frame_perftest.cc

Issue 6689014: GTTF: Detect browser crashes on shutdown in UI tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/perf/chrome_frame_perftest.cc
===================================================================
--- chrome_frame/test/perf/chrome_frame_perftest.cc (revision 80488)
+++ chrome_frame/test/perf/chrome_frame_perftest.cc (working copy)
@@ -1358,7 +1358,8 @@
bool RunSingleTestOutOfProc(const std::string& test_name) {
FilePath path;
- PathService::Get(base::DIR_EXE, &path);
+ if (!PathService::Get(base::DIR_EXE, &path))
+ return false;
path = path.Append(L"chrome_frame_tests.exe");
CommandLine cmd_line(path);
@@ -1384,6 +1385,8 @@
base::KillProcess(process_handle, -1, true);
}
+ base::CloseProcessHandle(process_handle);
+
return exit_code == 0;
}
« chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc ('K') | « chrome/test/ui/ui_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698