GTTF: Detect browser crashes on shutdown in UI tests.

chrome_frame/test/perf/chrome_frame_perftest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome_frame/test/perf/chrome_frame_perftest.h"
 
 #include <atlwin.h>
 #include <atlhost.h>
 #include <map>
 #include <vector>
 #include <string>
@@ skipping 1340 matching lines @@
                      const std::string& trace,
                      const std::string& values,
                      const std::string& units,
                      bool important) {
   PrintResultsImpl(measurement, modifier, trace, values,
       "[", "]", units, important);
 }
 
 bool RunSingleTestOutOfProc(const std::string& test_name) {
   FilePath path;
-  PathService::Get(base::DIR_EXE, &path);
+  if (!PathService::Get(base::DIR_EXE, &path))
+    return false;
   path = path.Append(L"chrome_frame_tests.exe");
 
   CommandLine cmd_line(path);
   // Always enable disabled tests.  This method is not called with disabled
   // tests unless this flag was specified to the browser test executable.
   cmd_line.AppendSwitch("gtest_also_run_disabled_tests");
   cmd_line.AppendSwitchASCII("gtest_filter", test_name);
 
   base::ProcessHandle process_handle;
   if (!base::LaunchApp(cmd_line, false, false, &process_handle))
     return false;
 
   int test_terminate_timeout_ms = 60 * 1000;
   int exit_code = 0;
   if (!base::WaitForExitCodeWithTimeout(process_handle, &exit_code,
     test_terminate_timeout_ms)) {
       LOG(ERROR) << "Test timeout (" << test_terminate_timeout_ms
         << " ms) exceeded for " << test_name;
 
       exit_code = -1;  // Set a non-zero exit code to signal a failure.
 
       // Ensure that the process terminates.
       base::KillProcess(process_handle, -1, true);
   }
 
+  base::CloseProcessHandle(process_handle);
+
   return exit_code == 0;
 }
 
 template <class Monitor>
 void PrintPerfTestResults(const Monitor* monitor,
                           int num_cycles,
                           const char* result_name) {
   std::string times;
 
   for (int i = 0; i < num_cycles; ++i) {
@@ skipping 73 matching lines @@
   PrintPerfTestResults(automation_provider_connect_monitor, kNumCycles,
                        "automationproviderconnect");
   PrintPerfTestResults(external_tab_navigate_monitor, kNumCycles,
                        "externaltabnavigate");
   PrintPerfTestResults(renderer_main_monitor, kNumCycles,
                        "beginrenderermain");
 #ifdef NDEBUG
   PrintPerfTestResults(pre_read_chrome_monitor, kNumCycles, "PreReadImage");
 #endif  // NDEBUG
 }