GTTF: Detect browser crashes on shutdown in UI tests.

chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc

Index: chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc
===================================================================
--- chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc	(revision 80488)
+++ chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc	(working copy)
@@ -54,6 +54,9 @@
   ASSERT_TRUE(automation()->WaitForAppModalDialog());
   ASSERT_TRUE(automation()->ClickAppModalDialogButton(
                   ui::MessageBoxFlags::DIALOGBUTTON_OK));
-  ASSERT_TRUE(WaitForBrowserProcessToQuit(
-      TestTimeouts::wait_for_terminate_timeout_ms()));
+
+  int exit_code = -1;
+  ASSERT_TRUE(launcher_->WaitForBrowserProcessToQuit(
+                  TestTimeouts::wait_for_terminate_timeout_ms(), &exit_code));

[Huyen, 2011/04/07 00:07:45]

Pawel, I think you forgot to include test_timeouts.h. I tried to build all
target and I'm getting an error:

chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc: In member
function ‘virtual void FastShutdown_SlowTermination_Test::TestBody()’:
chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc:59: error:
‘TestTimeouts’ was not declared in this scope

[Paweł Hajdan Jr., 2011/04/07 06:25:19]

Thank you for commenting here. I took a look at the side-by-side diff, and
TestTimeouts was used here before. Also, the change landed successfully on the
waterfall, which suggests it didn't introduce a compile failure.

Do you have any local changes that could make this fail to compile? I agree
though that test_timeouts.h should be explicitly #included here. Feel free to
TBR such a change to me.

+  EXPECT_EQ(0, exit_code);  // Expect a clean shutdown.
 }