Regression: Editor Linux Fix for gcl

Regression: Editor Linux Fix for gcl.

Editor doesn't come up due to Shell=True

BUG=none
TEST=linux and win works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77913

[Mohamed Mansour, 2011-03-12 03:13:24]

please look, sorry :(

[M-A Ruel, 2011-03-12 03:16:22]

lgtm

[jam, 2011-03-12 07:43:16]

I get the following errors with these gcl changes in command prompt in
Windows, so I've reverted them.  This is what I see:

A:\chrome2\src>gcl change
Traceback (most recent call last):
  File "A:\depot_tools\gcl.py", line 1403, in <module>
    sys.exit(main(sys.argv[1:]))
  File "A:\depot_tools\gcl.py", line 1383, in main
    return command(argv[1:])
  File "A:\depot_tools\gcl.py", line 1068, in CMDchange
    subprocess.check_call(['env', GetEditor(), filename])
  File "A:\depot_tools\python_bin\lib\subprocess.py", line 457, in
check_call
    retcode = call(*popenargs, **kwargs)
  File "A:\depot_tools\python_bin\lib\subprocess.py", line 444, in call
    return Popen(*popenargs, **kwargs).wait()
  File "A:\depot_tools\python_bin\lib\subprocess.py", line 595, in __init__
    errread, errwrite)
  File "A:\depot_tools\python_bin\lib\subprocess.py", line 804, in
_execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
Sending crash report ...
  exception: [Error 2] The system cannot find the file specifie
  args: ['A:\\depot_tools\\gcl.py', 'change']
  stack:   File "A:\depot_tools\gcl.py", line 1403, in <mod
  host: JABDELMALEK0-W.ad.corp.google.com
  version: 2.6.2 (r262:71600, Apr 21 2009, 15:05:37) [MSC v.1
  user: jabdelmalek
  cwd: A:\chrome2\src
A stack trace has been sent to the maintainers.


On Fri, Mar 11, 2011 at 7:13 PM, <mhm@chromium.org> wrote:

> Reviewers: Marc-Antoine Ruel, Lei Zhang,
>
> Message:
> please look, sorry :(
>
> Description:
> Regression: Editor Linux Fix for gcl.
>
> Editor doesn't come up due to Shell=True
>
> BUG=none
> TEST=linux and win works
>
> Please review this at http://codereview.chromium.org/6679023/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
>
> Affected files:
>  M     gcl.py
>  M     git_cl/git_cl.py
>
>
> Index: gcl.py
> ===================================================================
> --- gcl.py      (revision 77911)
> +++ gcl.py      (working copy)
> @@ -1066,7 +1066,7 @@
>   result = None
>   try:
>     if not silent:
> -      subprocess.check_call(['env', GetEditor(), filename], shell=True)
> +      subprocess.check_call(['env', GetEditor(), filename])
>     result = gclient_utils.FileRead(filename, 'r')
>   finally:
>     os.remove(filename)
> Index: git_cl/git_cl.py
> ===================================================================
> --- git_cl/git_cl.py    (revision 77911)
> +++ git_cl/git_cl.py    (working copy)
> @@ -712,7 +712,7 @@
>
>   result = None
>   try:
> -    subprocess.check_call(['env', editor, filename], shell=True)
> +    subprocess.check_call(['env', editor, filename])
>     fileobj = open(filename)
>     result = fileobj.read()
>     fileobj.close()
>
>
>

[Mohamed Mansour, 2011-03-12 14:56:53]

Hi John,

Can you please tell me the following information, it will help me setup that
environment in a VM so I can try to figure out what is wrong:

   - What version of Windows are you running?
   - What version of Python is in your depot_tools/python_bin folder?

Thanks,
Mohamed Mansour



On Sat, Mar 12, 2011 at 2:43 AM, John Abd-El-Malek <jam@chromium.org> wrote:

> I get the following errors with these gcl changes in command prompt in
> Windows, so I've reverted them.  This is what I see:
>
> A:\chrome2\src>gcl change
> Traceback (most recent call last):
>   File "A:\depot_tools\gcl.py", line 1403, in <module>
>     sys.exit(main(sys.argv[1:]))
>   File "A:\depot_tools\gcl.py", line 1383, in main
>     return command(argv[1:])
>   File "A:\depot_tools\gcl.py", line 1068, in CMDchange
>     subprocess.check_call(['env', GetEditor(), filename])
>   File "A:\depot_tools\python_bin\lib\subprocess.py", line 457, in
> check_call
>     retcode = call(*popenargs, **kwargs)
>   File "A:\depot_tools\python_bin\lib\subprocess.py", line 444, in call
>     return Popen(*popenargs, **kwargs).wait()
>   File "A:\depot_tools\python_bin\lib\subprocess.py", line 595, in __init__
>     errread, errwrite)
>   File "A:\depot_tools\python_bin\lib\subprocess.py", line 804, in
> _execute_child
>     startupinfo)
> WindowsError: [Error 2] The system cannot find the file specified
> Sending crash report ...
>   exception: [Error 2] The system cannot find the file specifie
>   args: ['A:\\depot_tools\\gcl.py', 'change']
>   stack:   File "A:\depot_tools\gcl.py", line 1403, in <mod
>   host: JABDELMALEK0-W.ad.corp.google.com
>   version: 2.6.2 (r262:71600, Apr 21 2009, 15:05:37) [MSC v.1
>   user: jabdelmalek
>   cwd: A:\chrome2\src
> A stack trace has been sent to the maintainers.
>
>
> On Fri, Mar 11, 2011 at 7:13 PM, <mhm@chromium.org> wrote:
>
>> Reviewers: Marc-Antoine Ruel, Lei Zhang,
>>
>> Message:
>> please look, sorry :(
>>
>> Description:
>> Regression: Editor Linux Fix for gcl.
>>
>> Editor doesn't come up due to Shell=True
>>
>> BUG=none
>> TEST=linux and win works
>>
>> Please review this at http://codereview.chromium.org/6679023/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
>>
>> Affected files:
>>  M     gcl.py
>>  M     git_cl/git_cl.py
>>
>>
>> Index: gcl.py
>> ===================================================================
>> --- gcl.py      (revision 77911)
>> +++ gcl.py      (working copy)
>> @@ -1066,7 +1066,7 @@
>>   result = None
>>   try:
>>     if not silent:
>> -      subprocess.check_call(['env', GetEditor(), filename], shell=True)
>> +      subprocess.check_call(['env', GetEditor(), filename])
>>     result = gclient_utils.FileRead(filename, 'r')
>>   finally:
>>     os.remove(filename)
>> Index: git_cl/git_cl.py
>> ===================================================================
>> --- git_cl/git_cl.py    (revision 77911)
>> +++ git_cl/git_cl.py    (working copy)
>> @@ -712,7 +712,7 @@
>>
>>   result = None
>>   try:
>> -    subprocess.check_call(['env', editor, filename], shell=True)
>> +    subprocess.check_call(['env', editor, filename])
>>     fileobj = open(filename)
>>     result = fileobj.read()
>>     fileobj.close()
>>
>>
>>
>