gcl.py - Issue 6679023: Regression: Editor Linux Fix for gcl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 6679023: Regression: Editor Linux Fix for gcl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Patch Set: '' Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: gcl.py

===================================================================

--- gcl.py (revision 77911)

+++ gcl.py (working copy)

@@ -1063,10 +1063,9 @@

os.write(handle, text)

os.close(handle)

- result = None

try:

if not silent:

- subprocess.check_call(['env', GetEditor(), filename], shell=True)

+ subprocess.check_call(['env', GetEditor(), filename])

result = gclient_utils.FileRead(filename, 'r')

finally:

os.remove(filename)

« no previous file with comments | « no previous file | git_cl/git_cl.py » ('j') | no next file with comments »