Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gcl.py

Issue 6679023: Regression: Editor Linux Fix for gcl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_cl/git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 77911)
+++ gcl.py (working copy)
@@ -1063,10 +1063,9 @@
os.write(handle, text)
os.close(handle)
- result = None
try:
if not silent:
- subprocess.check_call(['env', GetEditor(), filename], shell=True)
+ subprocess.check_call(['env', GetEditor(), filename])
result = gclient_utils.FileRead(filename, 'r')
finally:
os.remove(filename)
« no previous file with comments | « no previous file | git_cl/git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698