Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: git_cl/git_cl.py

Issue 6679023: Regression: Editor Linux Fix for gcl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gcl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl/git_cl.py
===================================================================
--- git_cl/git_cl.py (revision 77911)
+++ git_cl/git_cl.py (working copy)
@@ -710,9 +710,8 @@
fileobj.write(starting_text)
fileobj.close()
- result = None
try:
- subprocess.check_call(['env', editor, filename], shell=True)
+ subprocess.check_call(['env', editor, filename])
fileobj = open(filename)
result = fileobj.read()
fileobj.close()
« no previous file with comments | « gcl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698