Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1801)

Unified Diff: chrome/browser/debugger/debugger_remote_service.cc

Issue 6674006: Coverity Fixlets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CID=6283,3909 Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/debugger/debugger_remote_service.cc
diff --git a/chrome/browser/debugger/debugger_remote_service.cc b/chrome/browser/debugger/debugger_remote_service.cc
index d5e12b7f6ad8f566f24604e79847c8052f32be74..8dc0ff393e223e7d4adeff94c782752c5fcf2bea 100644
--- a/chrome/browser/debugger/debugger_remote_service.cc
+++ b/chrome/browser/debugger/debugger_remote_service.cc
@@ -295,7 +295,8 @@ bool DebuggerRemoteService::DispatchDebuggerCommand(int tab_uid,
}
std::string v8_command;
DictionaryValue* v8_command_value;
- content->GetDictionary(kDataKey, &v8_command_value);
+ if (!content->GetDictionary(kDataKey, &v8_command_value))
+ return true;
Lei Zhang 2011/03/11 01:09:35 I have no idea if this is right. I would leave thi
Sheridan Rawlins 2011/03/11 01:39:49 reverted
base::JSONWriter::Write(v8_command_value, false, &v8_command);
manager->ForwardToDevToolsAgent(
client_host, DevToolsAgentMsg_DebuggerCommand(v8_command));

Powered by Google App Engine
This is Rietveld 408576698