Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: chrome/browser/bookmarks/bookmark_index.cc

Issue 6674006: Coverity Fixlets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CID=6283,3909 Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_index.cc
diff --git a/chrome/browser/bookmarks/bookmark_index.cc b/chrome/browser/bookmarks/bookmark_index.cc
index c247cb53b6d0610500c2f356def9a92271e43192..119d4506492fb89268a16dfa1dd82095e2907427 100644
--- a/chrome/browser/bookmarks/bookmark_index.cc
+++ b/chrome/browser/bookmarks/bookmark_index.cc
@@ -129,10 +129,13 @@ void BookmarkIndex::ExtractBookmarkNodePairs(
for (NodeSet::const_iterator i = match.nodes_begin();
i != match.nodes_end(); ++i) {
- history::URLRow url;
- if (url_db)
- url_db->GetRowForURL((*i)->GetURL(), &url);
- NodeTypedCountPair pair(*i, url.typed_count());
+ int typed_count = 0;
Lei Zhang 2011/03/11 01:09:35 Sorry, not familiar with this code either. See not
Sheridan Rawlins 2011/03/11 01:39:49 reverted
+ if (url_db) {
+ history::URLRow url;
+ if (url_db->GetRowForURL((*i)->GetURL(), &url))
+ typed_count = url.typed_count();
+ }
+ NodeTypedCountPair pair(*i, typed_count);
node_typed_counts->push_back(pair);
}
}
« no previous file with comments | « no previous file | chrome/browser/debugger/debugger_remote_service.cc » ('j') | chrome/browser/debugger/debugger_remote_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698