Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 6667059: Initial contents for the new factory_test repo (Closed)

Created:
9 years, 9 months ago by jrbarnette
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Create the factory test upstart jobs. The initial job contents were taken from mod_for_factory_scripts/200patchInitScript, in the src/scripts repository. BUG=chromium-os:13258 TEST=Build and boot a factory test image Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9143fab

Patch Set 1 #

Patch Set 2 : Fix bug causing reversed applicaton of -c option to autotest #

Total comments: 1

Patch Set 3 : Re-upload after repository rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M LICENSE View 1 chunk +1 line, -1 line 0 comments Download
A factory.conf View 1 1 chunk +29 lines, -0 lines 0 comments Download
A factorylog.conf View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jrbarnette
This change is one of a set of four CLs that move selected bits of ...
9 years, 9 months ago (2011-03-17 22:34:43 UTC) #1
Nick Sanders
can you as a inherit codereview as well. With that, LGTM.
9 years, 9 months ago (2011-03-17 22:55:13 UTC) #2
Vince Laviano
LGTM, with a comment about the copyright notice. http://codereview.chromium.org/6667059/diff/2001/LICENSE File LICENSE (right): http://codereview.chromium.org/6667059/diff/2001/LICENSE#newcode1 LICENSE:1: // ...
9 years, 9 months ago (2011-03-17 22:59:23 UTC) #3
jrbarnette
On 2011/03/17 22:55:13, Nick Sanders wrote: > can you as a inherit codereview as well. ...
9 years, 9 months ago (2011-03-17 23:40:04 UTC) #4
jrbarnette
9 years, 9 months ago (2011-03-17 23:43:11 UTC) #5
On 2011/03/17 22:59:23, Vince Laviano wrote:
> LGTM, with a comment about the copyright notice.
> 
> http://codereview.chromium.org/6667059/diff/2001/LICENSE
> File LICENSE (right):
> 
> http://codereview.chromium.org/6667059/diff/2001/LICENSE#newcode1
> LICENSE:1: // Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
> I'm not a lawyer, but should this (and the copyright notice in the other
files)
> be "2010-2011" or "2010, 2011" to reflect that the original code that you're
> transplanting from the mod_for_factory_scripts dir existed prior to 2011?

For the LICENSE file the content was created in 2011, so that's what it should
say.

For the other content, I think it's a matter of corporate policy.  My
understanding
from other places I've worked is that legally, there's no need to mention older
dates.

Powered by Google App Engine
This is Rietveld 408576698