Add an ebuild for the new factorytest-init package

Add the chromeos-base/factorytest-init package.

BUG=chromium-os:13258
TEST=Build and boot a factory test image

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=289d459

[jrbarnette, 2011-03-17 22:38:45]

This change creates a new factorytest-init package, and is the first
step to moving function currently found in mod_image_for_test.sh 
into ebuilds.

The name "factorytest-init" was selected by analogy with 
"chromeos-init".  It's anticipated that in order to complete the
movement of mod_image_for_test.sh into ebuilds, there will need to 
be separate ebuilds for the upstart jobs associated with each kind 
of image.  The anticipated future package names are "dev-init" (to 
go with "chromeos-dev"), "test-init" (to go with "chromeos-test"), 
and "factoryinstall-init" (to go with "chromeos-factoryinstall").


This change is one of a set of four CLs that move selected bits of
code from mod_image_for_test into an ebuild.

The complete list of CLs (in order of the push operations)
  1) Initial contents for the new factory_test repo:
     http://codereview.chromium.org/6667059/
  2) Update the manifest file to include the new factory_test repo:
     http://codereview.chromium.org/6709010/
  3) Add an ebuild for the new factorytest-init package:
     http://codereview.chromium.org/6665047/
  4) Update mod_image_for_test to use the new factorytest-init package:
     http://codereview.chromium.org/6665048/

[Nick Sanders, 2011-03-17 23:19:52]

lgtm

[Nick Sanders, 2011-03-17 23:21:07]

oooops NOT lgtm

[Nick Sanders, 2011-03-17 23:23:29]

okay actually LGTM

[davidjames, 2011-03-17 23:55:33]

http://codereview.chromium.org/6665047/diff/2001/chromeos-base/factorytest-in...
File chromeos-base/factorytest-init/factorytest-init-9999.ebuild (right):

http://codereview.chromium.org/6665047/diff/2001/chromeos-base/factorytest-in...
chromeos-base/factorytest-init/factorytest-init-9999.ebuild:27:
CROS_WORKON_PROJECT="factory_test"
Can you add factory_test to the full manifest first? cros_workon needs this in
order to rev your ebuild and know what git hash to point at. Otherwise,
preflight will fail with an error explaining that it can't find the commit id.

[davidjames, 2011-03-18 00:03:12]

http://codereview.chromium.org/6665047/diff/2001/chromeos/scripts/build_packages
File chromeos/scripts/build_packages (right):

http://codereview.chromium.org/6665047/diff/2001/chromeos/scripts/build_packa...
chromeos/scripts/build_packages:189: PACKAGES="${PACKAGES}
chromeos-base/factorytest-init"
Could you split this into a separate CL? We need to wait until factorytest-init
is 'marked as stable' by the buildbot before it's added as a dependency for the
build.

[jrbarnette, 2011-03-18 00:23:39]

On 2011/03/18 00:03:12, davidjames wrote:
>
http://codereview.chromium.org/6665047/diff/2001/chromeos/scripts/build_packages
> File chromeos/scripts/build_packages (right):
> 
>
http://codereview.chromium.org/6665047/diff/2001/chromeos/scripts/build_packa...
> chromeos/scripts/build_packages:189: PACKAGES="${PACKAGES}
> chromeos-base/factorytest-init"
> Could you split this into a separate CL? We need to wait until
factorytest-init
> is 'marked as stable' by the buildbot before it's added as a dependency for
the
> build.

Done.  New CL is uploaded, and will be published soon.

[davidjames, 2011-03-18 00:34:47]

LGTM

[Vince Laviano, 2011-03-18 02:15:05]

LGTM with comments.

http://codereview.chromium.org/6665047/diff/6003/chromeos-base/factorytest-in...
File chromeos-base/factorytest-init/factorytest-init-9999.ebuild (right):

http://codereview.chromium.org/6665047/diff/6003/chromeos-base/factorytest-in...
chromeos-base/factorytest-init/factorytest-init-9999.ebuild:18: RDEPEND="\
Stylistic nit. The convention that I've seen is for the first dependency to be
on the same line as the open quote and for the close quote to be on the same
line as the last dependency. An example is the "Ebuild with Dependencies"
section of http://devmanual.gentoo.org/quickstart/index.html.

http://codereview.chromium.org/6665047/diff/6003/chromeos-base/factorytest-in...
chromeos-base/factorytest-init/factorytest-init-9999.ebuild:30: insinto
/etc/init
This may be overly paranoid, but we might want to precede this line with "dodir
/etc/init" to ensure that this directory exists before installing into it.

[jrbarnette, 2011-03-18 18:56:11]

I've uploaded fixes for the comments below.

http://codereview.chromium.org/6665047/diff/6003/chromeos-base/factorytest-in...
File chromeos-base/factorytest-init/factorytest-init-9999.ebuild (right):

http://codereview.chromium.org/6665047/diff/6003/chromeos-base/factorytest-in...
chromeos-base/factorytest-init/factorytest-init-9999.ebuild:18: RDEPEND="\
On 2011/03/18 02:15:05, Vince Laviano wrote:
> Stylistic nit. The convention that I've seen is for the first dependency to be
> on the same line as the open quote and for the close quote to be on the same
> line as the last dependency. An example is the "Ebuild with Dependencies"
> section of http://devmanual.gentoo.org/quickstart/index.html.

True.  I don't know what came over me here...

http://codereview.chromium.org/6665047/diff/6003/chromeos-base/factorytest-in...
chromeos-base/factorytest-init/factorytest-init-9999.ebuild:30: insinto
/etc/init
On 2011/03/18 02:15:05, Vince Laviano wrote:
> This may be overly paranoid, but we might want to precede this line with
"dodir
> /etc/init" to ensure that this directory exists before installing into it.

Ah.  Reading the relevant Gentoo docs, I see that we're not guaranteed
that the chromeos-init package will be merged before this package.
Which, sure enough, means we can't be guaranteed of the existence
of /etc/init...