Update mod_image_for_test to use the new factorytest-init package

Build factory test images using the new factorytest-init package.

This also deletes the code from mod_for_factory_scripts/200patchInitScript
that created the files that now come from the new package.

BUG=chromium-os:13258
TEST=Build and boot a factory test image

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ce8384d

[jrbarnette, 2011-03-17 22:36:50]

This change creates a new factorytest-init package, and is the first
step to moving function currently found in mod_image_for_test.sh 
into ebuilds.

The name "factorytest-init" was selected by analogy with 
"chromeos-init".  It's anticipated that in order to complete the
movement of mod_image_for_test.sh into ebuilds, there will need to 
be separate ebuilds for the upstart jobs associated with each kind 
of image.  The anticipated future package names are "dev-init" (to 
go with "chromeos-dev"), "test-init" (to go with "chromeos-test"), 
and "factoryinstall-init" (to go with "chromeos-factoryinstall").


This change is one of a set of four CLs that move selected bits of
code from mod_image_for_test into an ebuild.

The complete list of CLs (in order of the push operations)
  1) Initial contents for the new factory_test repo:
     http://codereview.chromium.org/6667059/
  2) Update the manifest file to include the new factory_test repo:
     http://codereview.chromium.org/6709010/
  3) Add an ebuild for the new factorytest-init package:
     http://codereview.chromium.org/6665047/
  4) Update mod_image_for_test to use the new factorytest-init package:
     http://codereview.chromium.org/6665048/

[jrbarnette, 2011-03-17 22:41:44]

On 2011/03/17 22:36:50, jrbarnette wrote:
> This change creates a new factorytest-init package, and is the first
> step to moving function currently found in mod_image_for_test.sh 
> into ebuilds.
> 
The comments in the initial mail for this CL are misleading; they were
intended for the step 3) CL.  This is the step 4) CL (the update to
mod_image_for_test).

[Nick Sanders, 2011-03-17 23:37:38]

lgtm

[Vince Laviano, 2011-03-18 02:45:45]

LGTM with a comment.

http://codereview.chromium.org/6665048/diff/4001/mod_image_for_test.sh
File mod_image_for_test.sh (right):

http://codereview.chromium.org/6665048/diff/4001/mod_image_for_test.sh#newcod...
mod_image_for_test.sh:239: factorytest-init $EMERGE_JOBS
Maybe use the "${FOO}" variable quoting style here for consistency with the rest
of the file.

[jrbarnette, 2011-03-18 20:31:48]

http://codereview.chromium.org/6665048/diff/4001/mod_image_for_test.sh
File mod_image_for_test.sh (right):

http://codereview.chromium.org/6665048/diff/4001/mod_image_for_test.sh#newcod...
mod_image_for_test.sh:239: factorytest-init $EMERGE_JOBS
On 2011/03/18 02:45:45, Vince Laviano wrote:
> Maybe use the "${FOO}" variable quoting style here for consistency with the
rest
> of the file.

The rest of the file had no consistency, either...

I've uploaded changes to fix this style nit and a large raft of others.

[jrbarnette, 2011-03-18 22:38:33]

On 2011/03/18 20:31:48, jrbarnette wrote:
> http://codereview.chromium.org/6665048/diff/4001/mod_image_for_test.sh
> File mod_image_for_test.sh (right):
> 
>
http://codereview.chromium.org/6665048/diff/4001/mod_image_for_test.sh#newcod...
> mod_image_for_test.sh:239: factorytest-init $EMERGE_JOBS
> On 2011/03/18 02:45:45, Vince Laviano wrote:
> > Maybe use the "${FOO}" variable quoting style here for consistency with the
> rest
> > of the file.
> 
> The rest of the file had no consistency, either...
> 
> I've uploaded changes to fix this style nit and a large raft of others.

... and now the style nits are fixed in a separate CL.  And Lo!  this change
is a 3-liner!