Fix memory leaks on x64...

src/x64/lithium-codegen-x64.cc

Index: src/x64/lithium-codegen-x64.cc
===================================================================
--- src/x64/lithium-codegen-x64.cc	(revision 7090)
+++ src/x64/lithium-codegen-x64.cc	(working copy)
@@ -259,8 +259,8 @@
 bool LCodeGen::GenerateJumpTable() {
   for (int i = 0; i < jump_table_.length(); i++) {
     JumpTableEntry* info = jump_table_[i];
-    __ bind(&(info->label_));
-    __ Jump(info->address_, RelocInfo::RUNTIME_ENTRY);
+    __ bind(info->label());
+    __ Jump(info->address(), RelocInfo::RUNTIME_ENTRY);
   }
   return !is_aborted();
 }
@@ -542,13 +542,14 @@
     // We often have several deopts to the same entry, reuse the last
     // jump entry if this is the case.
     if (jump_table_.length() > 0 &&
-        jump_table_[jump_table_.length() - 1]->address_ == entry) {
+        jump_table_[jump_table_.length() - 1]->address() == entry) {
       jump_info = jump_table_[jump_table_.length() - 1];
     } else {
-      jump_info = new JumpTableEntry(entry);
+      jump_info = new JumpTableEntry();
+      jump_info->SetAddress(entry);

[Lasse Reichstein, 2011/03/09 09:16:54]

Why?
Is there any advantage in this, relative to setting the address in the
constructor? (Because it does mean setting the same memory's value twice and
temporarily leaving the entry in an invalid state).

(On the other hand, if you do make it a list of JumpTableEntrys instead of
pointers to same, you might want a no-argument constructor and a setter that
initializes the object).

       jump_table_.Add(jump_info);
     }
-    __ j(cc, &jump_info->label_);
+    __ j(cc, jump_info->label());
   }
 }