Fix memory leaks on x64...

src/x64/lithium-codegen-x64.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 241 matching lines @@
     return instructions_->at(current_instruction_ + 1);
   } else {
     return NULL;
   }
 }
 
 
 bool LCodeGen::GenerateJumpTable() {
   for (int i = 0; i < jump_table_.length(); i++) {
     JumpTableEntry* info = jump_table_[i];
-    __ bind(&(info->label_));
-    __ Jump(info->address_, RelocInfo::RUNTIME_ENTRY);
+    __ bind(info->label());
+    __ Jump(info->address(), RelocInfo::RUNTIME_ENTRY);
   }
   return !is_aborted();
 }
 
 
 bool LCodeGen::GenerateDeferredCode() {
   ASSERT(is_generating());
   for (int i = 0; !is_aborted() && i < deferred_.length(); i++) {
     LDeferredCode* code = deferred_[i];
     __ bind(code->entry());
@@ skipping 261 matching lines @@
     return;
   }
 
   if (cc == no_condition) {
     __ Jump(entry, RelocInfo::RUNTIME_ENTRY);
   } else {
     JumpTableEntry* jump_info = NULL;
     // We often have several deopts to the same entry, reuse the last
     // jump entry if this is the case.
     if (jump_table_.length() > 0 &&
-        jump_table_[jump_table_.length() - 1]->address_ == entry) {
+        jump_table_[jump_table_.length() - 1]->address() == entry) {
       jump_info = jump_table_[jump_table_.length() - 1];
     } else {
-      jump_info = new JumpTableEntry(entry);
+      jump_info = new JumpTableEntry();
+      jump_info->SetAddress(entry);

[Lasse Reichstein, 2011/03/09 09:16:54]

Why?
Is there any advantage in this, relative to setting the address in the
constructor? (Because it does mean setting the same memory's value twice and
temporarily leaving the entry in an invalid state).

(On the other hand, if you do make it a list of JumpTableEntrys instead of
pointers to same, you might want a no-argument constructor and a setter that
initializes the object).

       jump_table_.Add(jump_info);
     }
-    __ j(cc, &jump_info->label_);
+    __ j(cc, jump_info->label());
   }
 }
 
 
 void LCodeGen::PopulateDeoptimizationData(Handle<Code> code) {
   int length = deoptimizations_.length();
   if (length == 0) return;
   ASSERT(FLAG_deopt);
   Handle<DeoptimizationInputData> data =
       Factory::NewDeoptimizationInputData(length, TENURED);
@@ skipping 3096 matching lines @@
   RegisterEnvironmentForDeoptimization(environment);
   ASSERT(osr_pc_offset_ == -1);
   osr_pc_offset_ = masm()->pc_offset();
 }
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64