Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: src/x64/lithium-codegen-x64.h

Issue 6647012: Fix memory leaks on x64... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | src/x64/lithium-codegen-x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/lithium-codegen-x64.h
===================================================================
--- src/x64/lithium-codegen-x64.h (revision 7090)
+++ src/x64/lithium-codegen-x64.h (working copy)
@@ -42,6 +42,7 @@
// Forward declarations.
class LDeferredCode;
class SafepointGenerator;
+class JumpTableEntry;
class LCodeGen BASE_EMBEDDED {
public:
@@ -240,13 +241,6 @@
// Emits code for pushing a constant operand.
void EmitPushConstantOperand(LOperand* operand);
- struct JumpTableEntry {
- inline JumpTableEntry(Address address)
- : label_(),
- address_(address) { }
- Label label_;
- Address address_;
- };
LChunk* const chunk_;
MacroAssembler* const masm_;
@@ -275,10 +269,24 @@
friend class LDeferredCode;
friend class LEnvironment;
friend class SafepointGenerator;
+ friend class JumpTableEntry;
DISALLOW_COPY_AND_ASSIGN(LCodeGen);
};
+class JumpTableEntry : public ZoneObject {
Lasse Reichstein 2011/03/09 09:16:54 Why create an external class for a purely internal
+ public:
+ explicit JumpTableEntry() : address_(NULL) { }
+ void SetAddress(Address address) { address_ = address; }
+ byte* address() { return address_; }
+ Label* label() { return &label_; }
+
+ private:
+ Label label_;
+ byte* address_;
+};
+
+
class LDeferredCode: public ZoneObject {
public:
explicit LDeferredCode(LCodeGen* codegen)
« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | src/x64/lithium-codegen-x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698