Issue 6628072: fix typos in CheckOwners()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6628072: fix typos in CheckOwners() (Closed)

Created:
9 years, 9 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

fix typos in CheckOwners() Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77361

Patch Set 2 : update w/ feedback from maruel #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	presubmit_canned_checks.py	View	1	1 chunk	+8 lines, -8 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/6628072/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/6628072/diff/1/presubmit_canned_checks.py#newcode630 presubmit_canned_checks.py:630: affected_files = set([str(f) for f in I usually ...

9 years, 9 months ago (2011-03-08 19:06:21 UTC) #2

Dirk Pranke

On 2011/03/08 19:06:21, Marc-Antoine Ruel wrote: > lgtm > > http://codereview.chromium.org/6628072/diff/1/presubmit_canned_checks.py > File presubmit_canned_checks.py (right): ...

9 years, 9 months ago (2011-03-08 22:28:22 UTC) #3