fix typos in CheckOwners()

presubmit_canned_checks.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
   """Requires that the changelist have a TEST= field."""
@@ skipping 609 matching lines @@
                   (builder_name, pending_builds_len))
   if out:
     return [output_api.PresubmitPromptWarning(
         'Build(s) pending. It is suggested to wait that no more than %d '
             'builds are pending.' % max_pendings,
         long_text='\n'.join(out))]
   return []
 
 
 def CheckOwners(input_api, output_api, source_file_filter=None):
-  affected_files = set(input_api.change.AffectedFiles(source_file_filter))
+  affected_files = set([str(f) for f in

[M-A Ruel, 2011/03/08 19:06:21]

I usually use f.LocalPath() to be clearer. I don't really care though.

+      input_api.change.AffectedFiles(source_file_filter)])
   owners_db = input_api.owners_db
 
-  if input_api.is_commiting:
+  if input_api.is_committing:
     missing_files = owners_db.FilesNotCoveredBy(affected_files,
                                                 input_api.change.approvers)
     if missing_files:
       return [output_api.PresubmitPromptWarning('Missing approvals for: %s' %
               ','.join(missing_files))]
     return []
-  else:
-    if not input_api.change.get('R', None):
-      suggested_reviewers = owners_db.OwnersFor(affected_files)
+  elif input_api.change.tags.get('R'):
+    return []
 
-      # TODO(dpranke): consider getting multiple covering sets of reviewers
-      # and displaying them somehow?
-      input_api.change['R'] = ','.join(suggested_reviewers)
+  suggested_reviewers = owners_db.ReviewersFor(affected_files)
+  # TODO(dpranke): Actually propagate the info back.
+  return []