Issue 660280: Parametrize C++ splay tree with allocator.

Issue 660280: Parametrize C++ splay tree with allocator. (Closed)

Created:
10 years, 9 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Parametrize C++ splay tree with allocator. Thus, now there is a "generic" SplayTree and its Zone-bound specialization ZoneSplayTree. This is needed for my reimplementation of profiler tree generation in C++. As generation is performed in a separate thread, Zone can't be used, because it intentionally not thread-safe. Committed: http://code.google.com/p/v8/source/detail?r=3990

Patch Set 1 #

Total comments: 6

Patch Set 2 : P -> Allocator #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+483 lines, -311 lines)			Patch
M	src/globals.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/splay-tree.h	View	1	1 chunk	+191 lines, -0 lines	0 comments	Download
A	src/splay-tree-inl.h	View	1	1 chunk	+276 lines, -0 lines	0 comments	Download
M	src/zone.h	View		1 chunk	+6 lines, -90 lines	0 comments	Download
M	src/zone.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/zone-inl.h	View		1 chunk	+6 lines, -221 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/660280/diff/1/2 File src/globals.h (right): http://codereview.chromium.org/660280/diff/1/2#newcode264 src/globals.h:264: template <typename Config, class P = FreeStoreAllocationPolicy> class ...

10 years, 9 months ago (2010-03-02 09:26:15 UTC) #2

mnaganov (inactive)

10 years, 9 months ago (2010-03-02 10:03:06 UTC) #3

http://codereview.chromium.org/660280/diff/1/2
File src/globals.h (right):

http://codereview.chromium.org/660280/diff/1/2#newcode264
src/globals.h:264: template <typename Config, class P =
FreeStoreAllocationPolicy> class SplayTree;
On 2010/03/02 09:26:16, Søren Gjesse wrote:
> I like Allocator instead of P better.

Done.

http://codereview.chromium.org/660280/diff/1/4
File src/splay-tree-inl.h (right):

http://codereview.chromium.org/660280/diff/1/4#newcode36
src/splay-tree-inl.h:36: 
On 2010/03/02 09:26:16, Søren Gjesse wrote:
> I guess you don't want to rename C to Config and P to Allocator in this file?

Renamed.

http://codereview.chromium.org/660280/diff/1/5
File src/splay-tree.h (right):

http://codereview.chromium.org/660280/diff/1/5#newcode49
src/splay-tree.h:49: // template <typename Config, class P =
FreeStoreAllocationPolicy>
On 2010/03/02 09:26:16, Søren Gjesse wrote:
> P -> Allocator?

Done.

Expand Messages | Collapse Messages