Issue 6599002: Detect overflow of contant pool in virtual frame compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6599002: Detect overflow of contant pool in virtual frame compiler. (Closed)

Created:
9 years, 10 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Detect overflow of contant pool in virtual frame compiler. Gracefully fallback to a different code pattern when that happens. BUG=http://crbug.com/61802 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=6964

Patch Set 1 #

Total comments: 1

Patch Set 2 : set untagged int32 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -4 lines)			Patch
M	src/frame-element.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	1 chunk	+17 lines, -3 lines	1 comment	Download
M	src/ia32/virtual-frame-ia32.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ia32/virtual-frame-ia32.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/virtual-frame-heavy-inl.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+12 lines, -1 line	0 comments	Download
M	src/x64/virtual-frame-x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM with comment. http://codereview.chromium.org/6599002/diff/1/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/6599002/diff/1/src/ia32/codegen-ia32.cc#newcode5371 src/ia32/codegen-ia32.cc:5371: frame_->Push(&temp); You may need to check ...

9 years, 10 months ago (2011-02-25 19:01:02 UTC) #2

Vyacheslav Egorov (Chromium)

Kevin, can you also take a quick look?

9 years, 9 months ago (2011-02-28 11:47:36 UTC) #3

Kevin Millikin (Chromium)

9 years, 9 months ago (2011-02-28 11:58:15 UTC) #4

LGTM.

http://codereview.chromium.org/6599002/diff/2002/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/6599002/diff/2002/src/ia32/codegen-ia32.cc#new...
src/ia32/codegen-ia32.cc:5369: if (node->handle()->IsSmi()) {
I think MacroAssembler::Set will do the right thing for all handles, so you
don't need to check for or handle (ha ha) smis specially.

Expand Messages | Collapse Messages