src/x64/codegen-x64.cc - Issue 6599002: Detect overflow of contant pool in virtual frame compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 6599002: Detect overflow of contant pool in virtual frame compiler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: set untagged int32 Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/codegen-x64.cc

diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc

index f47ba18473216cf0356f0ee4e7b974230470c7fd..783484e66331cc5cf6a80dcebb0587f10d18d668 100644

--- a/src/x64/codegen-x64.cc

+++ b/src/x64/codegen-x64.cc

@@ -4694,7 +4694,18 @@ void CodeGenerator::VisitVariableProxy(VariableProxy* node) {

void CodeGenerator::VisitLiteral(Literal* node) {

Comment cmnt(masm_, "[ Literal");

- frame_->Push(node->handle());

+ if (frame_->ConstantPoolOverflowed()) {

+ Result temp = allocator_->Allocate();

+ ASSERT(temp.is_valid());

+ if (node->handle()->IsSmi()) {

+ __ Move(temp.reg(), Smi::cast(*node->handle()));

+ } else {

+ __ movq(temp.reg(), node->handle(), RelocInfo::EMBEDDED_OBJECT);

+ }

+ frame_->Push(&temp);

+ } else {

+ frame_->Push(node->handle());

+ }

}