Issue 6580050: Factor fd sharing code in proxy and fix fd issues once and for all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6580050: Factor fd sharing code in proxy and fix fd issues once and for all. (Closed)

Created:
9 years, 10 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Factor fd sharing code in proxy and fix fd issues once and for all. BUG=none TEST=use flapper, go to youtube, make plugin crash and check no warning about close() failing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76026

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix review comments #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -72 lines)			Patch
M	ppapi/proxy/dispatcher.h	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
M	ppapi/proxy/dispatcher.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	1	4 chunks	+22 lines, -34 lines	0 comments	Download
M	ppapi/proxy/ppb_context_3d_proxy.cc	View	1	3 chunks	+14 lines, -11 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_file_proxy.cc	View		2 chunks	+10 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM with minor nits. http://codereview.chromium.org/6580050/diff/1/ppapi/proxy/dispatcher.cc File ppapi/proxy/dispatcher.cc (right): http://codereview.chromium.org/6580050/diff/1/ppapi/proxy/dispatcher.cc#newcode257 ppapi/proxy/dispatcher.cc:257: bool close_source) { Or maybe ...

9 years, 10 months ago (2011-02-25 01:25:03 UTC) #2

brettw

9 years, 10 months ago (2011-02-25 02:50:37 UTC) #3

Thanks for fixing this, I noticed that error when working on my last
patch but didn't have a chance to track it down yet.

Brett

Expand Messages | Collapse Messages