Factor fd sharing code in proxy and fix fd issues once and for all.

ppapi/proxy/ppb_context_3d_proxy.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_context_3d_proxy.h"
 
 #include "base/hash_tables.h"
 #include "gpu/command_buffer/client/gles2_cmd_helper.h"
 #include "gpu/command_buffer/client/gles2_implementation.h"
 #include "ppapi/c/pp_errors.h"
@@ skipping 113 matching lines @@
 
 
 const PPB_Context3D_Dev context_3d_interface = {
   &Create,
   &IsContext3D,
   &GetAttrib,
   &BindSurfaces,
   &GetBoundSurfaces,
 };
 
-base::SharedMemoryHandle SHMHandleFromInt(int shm_handle) {
-#if defined(OS_POSIX)
-  // The handle isn't ours to close, but we want to keep a reference to the
-  // handle until it is actually sent, so duplicate it, and mark auto-close.
-  return base::FileDescriptor(dup(shm_handle), true);
-#elif defined(OS_WIN)
-  // TODO(piman): DuplicateHandle to the plugin process.
-  return reinterpret_cast<HANDLE>(shm_handle);
+base::SharedMemoryHandle TransportSHMHandleFromInt(Dispatcher* dispatcher,
+                                                   int shm_handle) {
+  // TODO(piman): Change trusted interface to return a PP_FileHandle, those
+  // casts are ugly.
+  base::PlatformFile source =
+#if defined(OS_WIN)
+      reinterpret_cast<HANDLE>(static_cast<intptr_t>(shm_handle));
+#elif defined(OS_POSIX)
+      shm_handle;
 #else
-#error "Platform not supported."
+  #error Not implemented.
 #endif
+  // Don't close the handle, it doesn't belong to us.
+  return dispatcher->ShareHandleWithRemote(source, false);
 }
 
 gpu::CommandBuffer::State GPUStateFromPPState(
     const PP_Context3DTrustedState& s) {
   gpu::CommandBuffer::State state;
   state.num_entries = s.num_entries;
   state.get_offset = s.get_offset;
   state.put_offset = s.put_offset;
   state.token = s.token;
   state.error = static_cast<gpu::error::Error>(s.error);
@@ skipping 375 matching lines @@
     return;
 
   int shm_handle;
   uint32_t shm_size;
   if (!context_3d_trusted->GetRingBuffer(context.host_resource(),
                                          &shm_handle,
                                          &shm_size)) {
     return;
   }
 
-  *ring_buffer = SHMHandleFromInt(shm_handle);
+  *ring_buffer = TransportSHMHandleFromInt(dispatcher(), shm_handle);
 }
 
 void PPB_Context3D_Proxy::OnMsgGetState(const HostResource& context,
                                         gpu::CommandBuffer::State* state) {
   PP_Context3DTrustedState pp_state =
       ppb_context_3d_trusted()->GetState(context.host_resource());
   *state = GPUStateFromPPState(pp_state);
 }
 
 void PPB_Context3D_Proxy::OnMsgFlush(const HostResource& context,
@@ skipping 30 matching lines @@
     uint32* size) {
   *transfer_buffer = base::SharedMemory::NULLHandle();
   int shm_handle;
   uint32_t shm_size;
   if (!ppb_context_3d_trusted()->GetTransferBuffer(context.host_resource(),
                                                    id,
                                                    &shm_handle,
                                                    &shm_size)) {
     return;
   }
-  *transfer_buffer = SHMHandleFromInt(shm_handle);
+  *transfer_buffer = TransportSHMHandleFromInt(dispatcher(), shm_handle);
   *size = shm_size;
 }
 
 }  // namespace proxy
 }  // namespace pp