Factor fd sharing code in proxy and fix fd issues once and for all.

ppapi/proxy/dispatcher.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/dispatcher.h"
 
 #include <string.h>  // For memset.
 
 #include <map>
 
@@ skipping 234 matching lines @@
 
 void Dispatcher::SetSerializationRules(
     VarSerializationRules* var_serialization_rules) {
   serialization_rules_.reset(var_serialization_rules);
 }
 
 const void* Dispatcher::GetLocalInterface(const char* interface) {
   return local_get_interface_(interface);
 }
 
+IPC::PlatformFileForTransit Dispatcher::ShareHandleWithRemote(
+      base::PlatformFile handle,
+      bool close_source) {

[viettrungluu, 2011/02/25 01:25:03]

Or maybe |should_close_source|?

+  IPC::PlatformFileForTransit out_handle;
+#if defined(OS_WIN)
+  DWORD options = DUPLICATE_SAME_ACCESS;
+  if (close_source)
+    options |= DUPLICATE_CLOSE_SOURCE;
+  if (!::DuplicateHandle(::GetCurrentProcess(),
+                         handle,
+                         remote_process_handle_,
+                         &out_handle,
+                         0,
+                         FALSE,
+                         options))
+    out_handle = IPC::InvalidPlatformFileForTransit();
+#elif defined(OS_POSIX)
+  // If asked to close the source, we can simply re-use the source fd instead of
+  // dup()ing and close()ing.
+  int fd = close_source ? handle : ::dup(handle);
+  out_handle = base::FileDescriptor(fd, true);
+#else
+  #error Not implemented.
+#endif
+  return out_handle;
+}
+
 bool Dispatcher::Send(IPC::Message* msg) {
   if (test_sink_)
     return test_sink_->Send(msg);
   if (channel_.get())
     return channel_->Send(msg);
 
   // Remote side crashed, drop this message.
   delete msg;
   return false;
 }
 
 }  // namespace proxy
 }  // namespace pp