Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 6580024: Merge 75767 - It's not safe to delete the balloon view during MenuDelegate::S... (Closed)

Created:
9 years, 10 months ago by John Gregg
Modified:
9 years ago
Reviewers:
John Gregg
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 75767 - It's not safe to delete the balloon view during MenuDelegate::StoppedShowing, since it tears down the menu model. Do this as a delayed task instead. BUG=51177 TEST=autoclose notification with wrench menu open Review URL: http://codereview.chromium.org/6541082 TBR=johnnyg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
John Gregg
9 years, 10 months ago (2011-02-24 03:18:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698