Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: chrome/browser/ui/gtk/notifications/balloon_view_gtk.h

Issue 6580024: Merge 75767 - It's not safe to delete the balloon view during MenuDelegate::S... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/648/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Draws the view for the balloons. 5 // Draws the view for the balloons.
6 6
7 #ifndef CHROME_BROWSER_UI_GTK_NOTIFICATIONS_BALLOON_VIEW_GTK_H_ 7 #ifndef CHROME_BROWSER_UI_GTK_NOTIFICATIONS_BALLOON_VIEW_GTK_H_
8 #define CHROME_BROWSER_UI_GTK_NOTIFICATIONS_BALLOON_VIEW_GTK_H_ 8 #define CHROME_BROWSER_UI_GTK_NOTIFICATIONS_BALLOON_VIEW_GTK_H_
9 #pragma once 9 #pragma once
10 10
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 private: 57 private:
58 // NotificationObserver interface. 58 // NotificationObserver interface.
59 virtual void Observe(NotificationType type, 59 virtual void Observe(NotificationType type,
60 const NotificationSource& source, 60 const NotificationSource& source,
61 const NotificationDetails& details); 61 const NotificationDetails& details);
62 62
63 // ui::AnimationDelegate interface. 63 // ui::AnimationDelegate interface.
64 virtual void AnimationProgressed(const ui::Animation* animation); 64 virtual void AnimationProgressed(const ui::Animation* animation);
65 65
66 // Do the delayed close work. 66 // Do the delayed close work. The balloon and all view components will be
67 // destroyed at this time, so it shouldn't be called while still processing
68 // an event that relies on them.
67 void DelayedClose(bool by_user); 69 void DelayedClose(bool by_user);
68 70
69 // The height of the balloon's shelf. 71 // The height of the balloon's shelf.
70 // The shelf is where is close button is located. 72 // The shelf is where is close button is located.
71 int GetShelfHeight() const; 73 int GetShelfHeight() const;
72 74
73 // The width and height that the frame should be. If the balloon inside 75 // The width and height that the frame should be. If the balloon inside
74 // changes size, this will not be the same as the actual frame size until 76 // changes size, this will not be the same as the actual frame size until
75 // RepositionToBalloon() has been called and the animation completes. 77 // RepositionToBalloon() has been called and the animation completes.
76 int GetDesiredTotalWidth() const; 78 int GetDesiredTotalWidth() const;
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 // Is the menu currently showing? 132 // Is the menu currently showing?
131 bool menu_showing_; 133 bool menu_showing_;
132 134
133 // Is there a pending system-initiated close? 135 // Is there a pending system-initiated close?
134 bool pending_close_; 136 bool pending_close_;
135 137
136 DISALLOW_COPY_AND_ASSIGN(BalloonViewImpl); 138 DISALLOW_COPY_AND_ASSIGN(BalloonViewImpl);
137 }; 139 };
138 140
139 #endif // CHROME_BROWSER_UI_GTK_NOTIFICATIONS_BALLOON_VIEW_GTK_H_ 141 #endif // CHROME_BROWSER_UI_GTK_NOTIFICATIONS_BALLOON_VIEW_GTK_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698