It's not safe to delete the balloon view during MenuDelegate::StoppedShowing,...

It's not safe to delete the balloon view during MenuDelegate::StoppedShowing, since it tears down the menu model.  Do this as a delayed task instead.

BUG=51177
TEST=autoclose notification with wrench menu open


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75767

[Andrew T Wilson (Slow), 2011-02-23 00:43:58]

LGTM

http://codereview.chromium.org/6541082/diff/1/chrome/browser/ui/gtk/notificat...
File chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc (right):

http://codereview.chromium.org/6541082/diff/1/chrome/browser/ui/gtk/notificat...
chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc:468: }
So, is the intent that DelayedClose() should never be called directly, but only
via PostTask? If so, we should probably document this. I'm guessing the idea is
that it *could* be called directly, even though it isn't currently.

[John Gregg, 2011-02-23 00:57:56]

On 2011/02/23 00:43:58, Andrew T Wilson wrote:
> LGTM
> 
>
http://codereview.chromium.org/6541082/diff/1/chrome/browser/ui/gtk/notificat...
> File chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc (right):
> 
>
http://codereview.chromium.org/6541082/diff/1/chrome/browser/ui/gtk/notificat...
> chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc:468: }
> So, is the intent that DelayedClose() should never be called directly, but
only
> via PostTask? If so, we should probably document this. I'm guessing the idea
is
> that it *could* be called directly, even though it isn't currently.

I think the thing to document is that it shouldn't be called directly while
processing a UI event on the balloon, since the balloon will be destroyed
immediately.  I will add a comment.