Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 6578023: Make ICU build with Clang. ... (Closed)

Created:
9 years, 10 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Make ICU build with Clang. BUG=74018 TEST=ICU builds with Clang and -Wsign-compare turned on. TBR=thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M third_party/icu/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/icu/patches/clang.patch View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/icu/public/common/unicode/unistr.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
9 years, 10 months ago (2011-02-24 18:39:33 UTC) #1
Nico
9 years, 10 months ago (2011-02-24 18:41:44 UTC) #2
LG

you++ for the fast turnaround.

Powered by Google App Engine
This is Rietveld 408576698