Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/icu/patches/clang.patch

Issue 6578023: Make ICU build with Clang. ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/icu/README.chromium ('k') | third_party/icu/public/common/unicode/unistr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/icu/patches/clang.patch
===================================================================
--- third_party/icu/patches/clang.patch (revision 0)
+++ third_party/icu/patches/clang.patch (revision 0)
@@ -0,0 +1,13 @@
+Index: common/unicode/unistr.h
+===================================================================
+--- common/unicode/unistr.h (revision 75773)
++++ common/unicode/unistr.h (working copy)
+@@ -4089,7 +4089,7 @@
+ #if defined(__GNUC__)
+ // Ticket #7039: Clip length to the maximum valid length to the end of addressable memory given the starting address
+ // This is only an issue when using GCC and certain optimizations are turned on.
+- return extract(start, _length, dst, dst!=0 ? ((dst >= (char*)((size_t)-1) - UINT32_MAX) ? (((char*)UINT32_MAX) - dst) : UINT32_MAX) : 0, codepage);
++ return extract(start, _length, dst, dst!=0 ? ((dst >= (char*)((size_t)-1) - UINT32_MAX) ? static_cast<unsigned int>((((char*)UINT32_MAX) - dst)) : UINT32_MAX) : 0, codepage);
+ #else
+ return extract(start, _length, dst, dst!=0 ? 0xffffffff : 0, codepage);
+ #endif
Property changes on: third_party/icu/patches/clang.patch
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « third_party/icu/README.chromium ('k') | third_party/icu/public/common/unicode/unistr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698