third_party/icu/patches/clang.patch - Issue 6578023: Make ICU build with Clang. ...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/icu/patches/clang.patch

Issue 6578023: Make ICU build with Clang. ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 Index: common/unicode/unistr.h

	2 ===================================================================

	3 --- common/unicode/unistr.h (revision 75773)

	4 +++ common/unicode/unistr.h (working copy)

	5 @@ -4089,7 +4089,7 @@

	6 #if defined(__GNUC__)

	7 // Ticket #7039: Clip length to the maximum valid length to the end of addres sable memory given the starting address

	8 // This is only an issue when using GCC and certain optimizations are turned on.

	9 - return extract(start, _length, dst, dst!=0 ? ((dst >= (char)((size_t)-1) - U INT32_MAX) ? (((char)UINT32_MAX) - dst) : UINT32_MAX) : 0, codepage);

	10 + return extract(start, _length, dst, dst!=0 ? ((dst >= (char)((size_t)-1) - U INT32_MAX) ? static_cast<unsigned int>((((char)UINT32_MAX) - dst)) : UINT32_MAX ) : 0, codepage);

	11 #else

	12 return extract(start, _length, dst, dst!=0 ? 0xffffffff : 0, codepage);

	13 #endif

OLD	NEW

« no previous file with comments | « third_party/icu/README.chromium ('k') | third_party/icu/public/common/unicode/unistr.h » ('j') | no next file with comments »