Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 6576005: Fix bug introduced in r51121: gcl upload crashes on a 'revived' file. (Closed)

Created:
9 years, 10 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel, gavinp
Visibility:
Public.

Description

Fix bug introduced in r51121: gcl upload crashes on a 'revived' file. To reproduce, svn delete a file, then svn merge -c -N the file to revive it. Also fix a unit test that was broken for a while. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75835

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M scm.py View 2 chunks +9 lines, -1 line 2 comments Download
M tests/presubmit_unittest.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
Original review introducing this problem: http://codereview.chromium.org/2824035
9 years, 10 months ago (2011-02-23 20:13:14 UTC) #1
nsylvain
LGTM http://codereview.chromium.org/6576005/diff/1/scm.py File scm.py (right): http://codereview.chromium.org/6576005/diff/1/scm.py#newcode713 scm.py:713: # revision the file was deleted. The new ...
9 years, 10 months ago (2011-02-23 22:08:35 UTC) #2
M-A Ruel
9 years, 10 months ago (2011-02-24 01:37:58 UTC) #3
http://codereview.chromium.org/6576005/diff/1/scm.py
File scm.py (right):

http://codereview.chromium.org/6576005/diff/1/scm.py#newcode713
scm.py:713: # revision the file was deleted.
On 2011/02/23 22:08:35, nsylvain wrote:
> The new file most likely has a mergeinfo property you could look at. But i
would
> not worry too much about it.
> You may also want to just use "cat" instead of "diff" when this happens.

The idea is to not use the svn:mergeinfo metadata since I'd like to know which
revision the file was deleted at. I'll keep 'diff' to use a single code path.

Powered by Google App Engine
This is Rietveld 408576698