Fix bug introduced in r51121: gcl upload crashes on a 'revived' file.

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 # pylint is too confused.
 # pylint: disable=E1101,E1103,W0212,W0403
 
@@ skipping 239 matching lines @@
         binary, 'svn:mime-type').AndReturn('application/octet-stream')
     presubmit.scm.SVN.GetFileProperty(
         notfound, 'svn:mime-type').AndReturn('')
     presubmit.scm.SVN.CaptureInfo(blat).AndReturn(
             {'URL': 'svn:/foo/foo/blat.cc'})
     presubmit.scm.SVN.CaptureInfo(binary).AndReturn(
         {'URL': 'svn:/foo/binary.dll'})
     presubmit.scm.SVN.CaptureInfo(notfound).AndReturn({})
     presubmit.scm.SVN.CaptureInfo(flap).AndReturn(
             {'URL': 'svn:/foo/boo/flap.h'})
-    presubmit.scm.SVN.GenerateDiff(blat).AndReturn(self.presubmit_diffs)
-    presubmit.scm.SVN.GenerateDiff(notfound).AndReturn(self.presubmit_diffs)
+    presubmit.scm.SVN.GenerateDiff([blat]).AndReturn(self.presubmit_diffs)
+    presubmit.scm.SVN.GenerateDiff([notfound]).AndReturn(self.presubmit_diffs)
 
     self.mox.ReplayAll()
 
     change = presubmit.SvnChange('mychange', '\n'.join(description_lines),
                                  self.fake_root_dir, files, 0, 0)
     self.failUnless(change.Name() == 'mychange')
     self.failUnless(change.DescriptionText() ==
                     'Hello there\nthis is a change\nand some more regular text')
     self.failUnless(change.FullDescriptionText() ==
                     '\n'.join(description_lines))
@@ skipping 497 matching lines @@
     presubmit.scm.SVN.CaptureInfo(beingdeleted).AndReturn({})
     presubmit.scm.SVN.CaptureInfo(notfound).AndReturn({})
     presubmit.scm.SVN.GetFileProperty(blat, 'svn:mime-type').AndReturn(None)
     presubmit.scm.SVN.GetFileProperty(readme, 'svn:mime-type').AndReturn(None)
     presubmit.scm.SVN.GetFileProperty(binary, 'svn:mime-type').AndReturn(
         'application/octet-stream')
     presubmit.scm.SVN.GetFileProperty(weird, 'svn:mime-type').AndReturn(None)
     presubmit.scm.SVN.GetFileProperty(another, 'svn:mime-type').AndReturn(None)
     presubmit.scm.SVN.GetFileProperty(third_party, 'svn:mime-type'
         ).AndReturn(None)
-    presubmit.scm.SVN.GenerateDiff(blat).AndReturn(self.presubmit_diffs)
-    presubmit.scm.SVN.GenerateDiff(another).AndReturn(self.presubmit_diffs)
+    presubmit.scm.SVN.GenerateDiff([blat]).AndReturn(self.presubmit_diffs)
+    presubmit.scm.SVN.GenerateDiff([another]).AndReturn(self.presubmit_diffs)
 
     self.mox.ReplayAll()
 
     change = presubmit.SvnChange('mychange', '\n'.join(description_lines),
                                  self.fake_root_dir, files, 0, 0)
     input_api = presubmit.InputApi(change,
                                    join(self.fake_root_dir, 'foo',
                                         'PRESUBMIT.py'),
                                    False)
     # Doesn't filter much
@@ skipping 1038 matching lines @@
     results = presubmit_canned_checks.CheckBuildbotPendingBuilds(
         input_api, presubmit.OutputApi, 'uurl', 2, ('foo'))
     self.assertEquals(len(results), 1)
     self.assertEquals(results[0].__class__,
         presubmit.OutputApi.PresubmitNotifyResult)
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()