tests/presubmit_unittest.py - Issue 6576005: Fix bug introduced in r51121: gcl upload crashes on a 'revived' file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/presubmit_unittest.py

Issue 6576005: Fix bug introduced in r51121: gcl upload crashes on a 'revived' file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/presubmit_unittest.py

diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py

index 679a574e3faeb4784b05d30c396f74a46a495387..8c0c5d664e7a65f58ab038a74adf9bae5822ff6d 100755

--- a/tests/presubmit_unittest.py

+++ b/tests/presubmit_unittest.py

@@ -257,8 +257,8 @@ class PresubmitUnittest(PresubmitTestsBase):

presubmit.scm.SVN.CaptureInfo(notfound).AndReturn({})

presubmit.scm.SVN.CaptureInfo(flap).AndReturn(

{'URL': 'svn:/foo/boo/flap.h'})

- presubmit.scm.SVN.GenerateDiff(blat).AndReturn(self.presubmit_diffs)

- presubmit.scm.SVN.GenerateDiff(notfound).AndReturn(self.presubmit_diffs)

+ presubmit.scm.SVN.GenerateDiff([blat]).AndReturn(self.presubmit_diffs)

+ presubmit.scm.SVN.GenerateDiff([notfound]).AndReturn(self.presubmit_diffs)

self.mox.ReplayAll()

@@ -776,8 +776,8 @@ class InputApiUnittest(PresubmitTestsBase):

presubmit.scm.SVN.GetFileProperty(another, 'svn:mime-type').AndReturn(None)

presubmit.scm.SVN.GetFileProperty(third_party, 'svn:mime-type'

).AndReturn(None)

- presubmit.scm.SVN.GenerateDiff(blat).AndReturn(self.presubmit_diffs)

- presubmit.scm.SVN.GenerateDiff(another).AndReturn(self.presubmit_diffs)

+ presubmit.scm.SVN.GenerateDiff([blat]).AndReturn(self.presubmit_diffs)

+ presubmit.scm.SVN.GenerateDiff([another]).AndReturn(self.presubmit_diffs)

self.mox.ReplayAll()

« scm.py ('K') | « scm.py ('k') | no next file » | no next file with comments »