Modify crash-reporter to collect crash information for unofficial builds.

Modify crash-reporter to collect crash information for unofficial builds.

BUG=chromium-os:12207
TESTS=logging_UserCrash, logging_CrashSender, manual test which involves
purposely crashing a test to determine if minidump information is properly
collected

Change-Id: Id2195125289a695515b1722442116d6a6d9c4895

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cb5a147

[thieule, 2011-02-23 01:31:33]

Second of two CLs to add support for preserving minidumps on unofficial image.

The first CL can be found at http://codereview.chromium.org/6557003/.

PTAL

[kmixter1, 2011-02-23 04:49:02]

http://codereview.chromium.org/6559003/diff/1/crash_collector.cc
File crash_collector.cc (right):

http://codereview.chromium.org/6559003/diff/1/crash_collector.cc#newcode430
crash_collector.cc:430: bool CrashCollector::IsCrashTestInProgress() {
Use file_util::PathExists.

http://codereview.chromium.org/6559003/diff/1/user_collector.cc
File user_collector.cc (right):

http://codereview.chromium.org/6559003/diff/1/user_collector.cc#newcode477
user_collector.cc:477: if (!IsOfficialBuild() && !IsCrashTestInProgress()) {
Instead of IsOfficialBuild - could you use kLeaveCoreFile?  That file exists for
developer builds and its purpose is to leave diagnostics - this seems like
basically the same purpose, and ==developer is a little more specific than
!=official

[thieule, 2011-02-23 21:03:04]

Addressed code review feedbacks.

PTAL

http://codereview.chromium.org/6559003/diff/1/crash_collector.cc
File crash_collector.cc (right):

http://codereview.chromium.org/6559003/diff/1/crash_collector.cc#newcode430
crash_collector.cc:430: bool CrashCollector::IsCrashTestInProgress() {
On 2011/02/23 04:49:02, kmixter1 wrote:
> Use file_util::PathExists.

Done.

http://codereview.chromium.org/6559003/diff/1/user_collector.cc
File user_collector.cc (right):

http://codereview.chromium.org/6559003/diff/1/user_collector.cc#newcode477
user_collector.cc:477: if (!IsOfficialBuild() && !IsCrashTestInProgress()) {
On 2011/02/23 04:49:02, kmixter1 wrote:
> Instead of IsOfficialBuild - could you use kLeaveCoreFile?  That file exists
for
> developer builds and its purpose is to leave diagnostics - this seems like
> basically the same purpose, and ==developer is a little more specific than
> !=official

Done.

[kmixter1, 2011-02-26 04:52:19]

LGTM