Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: user_collector.cc

Issue 6559003: Modify crash-reporter to collect crash information for unofficial builds. (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git@master
Patch Set: Address code review feedbacks Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « crash_collector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: user_collector.cc
diff --git a/user_collector.cc b/user_collector.cc
index 6e6c76596c649c3a6b696c4f35daeb951c747ab9..13df5ce91d4a9c2a62190df1cc31c0b17ae08bfd 100644
--- a/user_collector.cc
+++ b/user_collector.cc
@@ -472,6 +472,13 @@ bool UserCollector::HandleCrash(const std::string &crash_attributes,
logger_->LogWarning("Received crash notification for %s[%d] sig %d (%s)",
exec.c_str(), pid, signal, handling_string);
+ // For developer builds, we always want to keep the crash reports unless
+ // we're testing the crash facilities themselves.
+ if (file_util::PathExists(FilePath(kLeaveCoreFile)) &&
+ !IsCrashTestInProgress()) {
+ feedback = true;
+ }
+
if (feedback) {
count_crash_function_();
« no previous file with comments | « crash_collector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698