Issue 6541036: Take out incorrect usage of MessageLoop::SetNestableTasksAllowed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6541036: Take out incorrect usage of MessageLoop::SetNestableTasksAllowed. (Closed)

Created:
9 years, 10 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, M-A Ruel

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Take out incorrect usage of MessageLoop::SetNestableTasksAllowed. BUG=73466 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75460

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/printing/print_job_worker.cc	View	1	2 chunks	+7 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

On Fri, Feb 18, 2011 at 2:11 PM, <thestig@chromium.org> wrote: > LGTM > > You ...

9 years, 10 months ago (2011-02-18 22:39:12 UTC) #3

M-A Ruel

9 years, 10 months ago (2011-02-19 01:45:43 UTC) #4

http://codereview.chromium.org/6541036/diff/2002/chrome/browser/printing/prin...
File chrome/browser/printing/print_job_worker.cc (right):

http://codereview.chromium.org/6541036/diff/2002/chrome/browser/printing/prin...
chrome/browser/printing/print_job_worker.cc:87:
printing_context_->set_use_overlays(use_overlays);
You want to move this to printing/printing_context_win.cc line 190:

  if ((*print_dialog_func_)(&dialog_options) != S_OK) {

print_dialog_func_ is initialized to &PrintDlgEx at line 132. I don't think it's
useful to keep a comment here.

Expand Messages | Collapse Messages