Take out incorrect usage of MessageLoop::SetNestableTasksAllowed.

chrome/browser/printing/print_job_worker.cc

Index: chrome/browser/printing/print_job_worker.cc
===================================================================
--- chrome/browser/printing/print_job_worker.cc	(revision 75400)
+++ chrome/browser/printing/print_job_worker.cc	(working copy)
@@ -80,7 +80,10 @@
 
   // Recursive task processing is needed for the dialog in case it needs to be
   // destroyed by a task.
-  MessageLoop::current()->SetNestableTasksAllowed(true);
+  // TODO: this code is wrong, SetNestableTasksAllowed(true) is needed on the
+  // thread where the PrintDlgEx is called, and definitely both calls should
+  // happen on the same thread. See http://crbug.com/73466
+  // MessageLoop::current()->SetNestableTasksAllowed(true);
   printing_context_->set_use_overlays(use_overlays);

[M-A Ruel, 2011/02/19 01:45:43]

You want to move this to printing/printing_context_win.cc line 190:

  if ((*print_dialog_func_)(&dialog_options) != S_OK) {

print_dialog_func_ is initialized to &PrintDlgEx at line 132. I don't think it's
useful to keep a comment here.

 
   if (ask_user_for_settings) {
@@ -98,7 +101,9 @@
 void PrintJobWorker::GetSettingsDone(PrintingContext::Result result) {
   // Most PrintingContext functions may start a message loop and process
   // message recursively, so disable recursive task processing.
-  MessageLoop::current()->SetNestableTasksAllowed(false);
+  // TODO: see above comment.  SetNestableTasksAllowed(false) needs to be called
+  // on the same thread as the previous call.  See http://crbug.com/73466
+  // MessageLoop::current()->SetNestableTasksAllowed(false);
 
   // We can't use OnFailure() here since owner_ may not support notifications.