Take out incorrect usage of MessageLoop::SetNestableTasksAllowed.

chrome/browser/printing/print_job_worker.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_job_worker.h"
 
 #include "base/message_loop.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/printing/print_job.h"
@@ skipping 62 matching lines @@
 void PrintJobWorker::GetSettings(bool ask_user_for_settings,
                                  gfx::NativeView parent_view,
                                  int document_page_count,
                                  bool has_selection,
                                  bool use_overlays) {
   DCHECK_EQ(message_loop(), MessageLoop::current());
   DCHECK_EQ(page_number_, PageNumber::npos());
 
   // Recursive task processing is needed for the dialog in case it needs to be
   // destroyed by a task.
-  MessageLoop::current()->SetNestableTasksAllowed(true);
+  // TODO: this code is wrong, SetNestableTasksAllowed(true) is needed on the
+  // thread where the PrintDlgEx is called, and definitely both calls should
+  // happen on the same thread. See http://crbug.com/73466
+  // MessageLoop::current()->SetNestableTasksAllowed(true);
   printing_context_->set_use_overlays(use_overlays);

[M-A Ruel, 2011/02/19 01:45:43]

You want to move this to printing/printing_context_win.cc line 190:

  if ((*print_dialog_func_)(&dialog_options) != S_OK) {

print_dialog_func_ is initialized to &PrintDlgEx at line 132. I don't think it's
useful to keep a comment here.

 
   if (ask_user_for_settings) {
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         NewRunnableMethod(this, &PrintJobWorker::GetSettingsWithUI,
                           parent_view, document_page_count,
                           has_selection));
   } else {
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
         NewRunnableMethod(this, &PrintJobWorker::UseDefaultSettings));
   }
 }
 
 void PrintJobWorker::GetSettingsDone(PrintingContext::Result result) {
   // Most PrintingContext functions may start a message loop and process
   // message recursively, so disable recursive task processing.
-  MessageLoop::current()->SetNestableTasksAllowed(false);
+  // TODO: see above comment.  SetNestableTasksAllowed(false) needs to be called
+  // on the same thread as the previous call.  See http://crbug.com/73466
+  // MessageLoop::current()->SetNestableTasksAllowed(false);
 
   // We can't use OnFailure() here since owner_ may not support notifications.
 
   // PrintJob will create the new PrintedDocument.
   owner_->message_loop()->PostTask(FROM_HERE, NewRunnableMethod(
       owner_,
       &PrintJobWorkerOwner::GetSettingsDone,
       printing_context_->settings(),
       result));
 }
@@ skipping 194 matching lines @@
     printing::PrintJobWorker* obj) {
   DCHECK(!owner_.get());
   owner_ = obj->owner_;
 }
 
 void RunnableMethodTraits<printing::PrintJobWorker>::ReleaseCallee(
     printing::PrintJobWorker* obj) {
   DCHECK_EQ(owner_, obj->owner_);
   owner_ = NULL;
 }