Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_url_provider.cc
===================================================================
--- chrome/browser/autocomplete/history_url_provider.cc (revision 75278)
+++ chrome/browser/autocomplete/history_url_provider.cc (working copy)
@@ -742,7 +742,7 @@
// keep this one since it is rated the highest.
HistoryMatches::iterator first(std::find_first_of(
matches->begin(), matches->end(), remove.begin(), remove.end()));
- DCHECK(first != matches->end()) <<
+ DCHECK(first == matches->end()) <<
Robert Sesek 2011/02/17 17:17:32 DCHECK_NE?
KushalP 2011/02/17 17:38:11 This uses an iterator and breaks DCHECK_NE and _EQ
"We should have always found at least the original URL.";
// Find any following occurrences of any URL in the redirect chain, these

Powered by Google App Engine
This is Rietveld 408576698