chrome/browser/autofill/autofill_dialog_controller_mac.mm - Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_dialog_controller_mac.mm

Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/history_url_provider.cc ('K') | « chrome/browser/autofill/autofill_cc_infobar_win.cc ('k') | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_dialog_controller_mac.mm

===================================================================

--- chrome/browser/autofill/autofill_dialog_controller_mac.mm (revision 75278)

+++ chrome/browser/autofill/autofill_dialog_controller_mac.mm (working copy)

@@ -335,7 +335,7 @@

- (void)addressAddDidEnd:(NSWindow*)sheet

returnCode:(int)returnCode

contextInfo:(void*)contextInfo {

- DCHECK(contextInfo == NULL);

+ DCHECK(!contextInfo);

if (returnCode) {

// Create a new address and save it to the |profiles_| list.

@@ -362,7 +362,7 @@

- (void)creditCardAddDidEnd:(NSWindow *)sheet

Robert Sesek 2011/02/17 17:17:32 nit: while you're here, remove the space between N

KushalP 2011/02/17 17:38:11 Done.

returnCode:(int)returnCode

contextInfo:(void *)contextInfo {

Robert Sesek 2011/02/17 17:17:32 same here

KushalP 2011/02/17 17:38:11 Done.

- DCHECK(contextInfo == NULL);

+ DCHECK(!contextInfo);

if (returnCode) {

// Create a new credit card and save it to the |creditCards_| list.