Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/...

chrome/browser/autocomplete/history_url_provider.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/history_url_provider.h"
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/message_loop.h"
@@ skipping 724 matching lines @@
 size_t HistoryURLProvider::RemoveSubsequentMatchesOf(
     HistoryMatches* matches,
     size_t source_index,
     const std::vector<GURL>& remove) const {
   size_t next_index = source_index + 1;  // return value = item after source
 
   // Find the first occurrence of any URL in the redirect chain. We want to
   // keep this one since it is rated the highest.
   HistoryMatches::iterator first(std::find_first_of(
       matches->begin(), matches->end(), remove.begin(), remove.end()));
-  DCHECK(first != matches->end()) <<
+  DCHECK(first == matches->end()) <<

[Robert Sesek, 2011/02/17 17:17:32]

DCHECK_NE?

[KushalP, 2011/02/17 17:38:11]

This uses an iterator and breaks DCHECK_NE and _EQ so needs to be left as is.
Sadly, I fudged it up and used == instead of !=.

On 2011/02/17 17:17:32, rsesek wrote:

       "We should have always found at least the original URL.";
 
   // Find any following occurrences of any URL in the redirect chain, these
   // should be deleted.
   HistoryMatches::iterator next(first);
   next++;  // Start searching immediately after the one we found already.
   while (next != matches->end() &&
          (next = std::find_first_of(next, matches->end(), remove.begin(),
                                     remove.end())) != matches->end()) {
     // Remove this item. When we remove an item before the source index, we
@@ skipping 49 matching lines @@
         &match.contents_class);
   }
   match.description = info.title();
   AutocompleteMatch::ClassifyMatchInString(params->input.text(),
                                            info.title(),
                                            ACMatchClassification::NONE,
                                            &match.description_class);
 
   return match;
 }