Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/...

chrome/browser/autocomplete/history_url_provider.cc

Index: chrome/browser/autocomplete/history_url_provider.cc
===================================================================
--- chrome/browser/autocomplete/history_url_provider.cc	(revision 75278)
+++ chrome/browser/autocomplete/history_url_provider.cc	(working copy)
@@ -742,7 +742,7 @@
   // keep this one since it is rated the highest.
   HistoryMatches::iterator first(std::find_first_of(
       matches->begin(), matches->end(), remove.begin(), remove.end()));
-  DCHECK(first != matches->end()) <<
+  DCHECK(first == matches->end()) <<

[Robert Sesek, 2011/02/17 17:17:32]

DCHECK_NE?

[KushalP, 2011/02/17 17:38:11]

This uses an iterator and breaks DCHECK_NE and _EQ so needs to be left as is.
Sadly, I fudged it up and used == instead of !=.

On 2011/02/17 17:17:32, rsesek wrote:

       "We should have always found at least the original URL.";
 
   // Find any following occurrences of any URL in the redirect chain, these