chrome/browser/appcache/appcache_dispatcher_host.cc - Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/appcache/appcache_dispatcher_host.cc

Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/appcache/appcache_frontend_proxy.cc » ('j') | chrome/browser/autocomplete/autocomplete_edit_view_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/appcache/appcache_dispatcher_host.cc

===================================================================

--- chrome/browser/appcache/appcache_dispatcher_host.cc (revision 75286)

+++ chrome/browser/appcache/appcache_dispatcher_host.cc (working copy)

@@ -217,21 +217,21 @@

void AppCacheDispatcherHost::GetStatusCallback(

appcache::Status status, void* param) {

IPC::Message* reply_msg = reinterpret_cast<IPC::Message*>(param);

- DCHECK(reply_msg == pending_reply_msg_.get());

+ DCHECK_EQ(reply_msg, pending_reply_msg_.get());

AppCacheMsg_GetStatus::WriteReplyParams(reply_msg, status);

Send(pending_reply_msg_.release());

}

void AppCacheDispatcherHost::StartUpdateCallback(bool result, void* param) {

IPC::Message* reply_msg = reinterpret_cast<IPC::Message*>(param);

- DCHECK(reply_msg == pending_reply_msg_.get());

+ DCHECK_EQ(reply_msg, pending_reply_msg_.get());

AppCacheMsg_StartUpdate::WriteReplyParams(reply_msg, result);

Send(pending_reply_msg_.release());

}

void AppCacheDispatcherHost::SwapCacheCallback(bool result, void* param) {

IPC::Message* reply_msg = reinterpret_cast<IPC::Message*>(param);

- DCHECK(reply_msg == pending_reply_msg_.get());

+ DCHECK_EQ(reply_msg, pending_reply_msg_.get());

AppCacheMsg_SwapCache::WriteReplyParams(reply_msg, result);

Send(pending_reply_msg_.release());

}