Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/...

chrome/browser/autocomplete/autocomplete_edit_view_win.cc

Index: chrome/browser/autocomplete/autocomplete_edit_view_win.cc
===================================================================
--- chrome/browser/autocomplete/autocomplete_edit_view_win.cc	(revision 75286)
+++ chrome/browser/autocomplete/autocomplete_edit_view_win.cc	(working copy)
@@ -357,7 +357,7 @@
 class PaintPatcher {
  public:
   PaintPatcher() : refcount_(0) { }
-  ~PaintPatcher() { DCHECK(refcount_ == 0); }
+  ~PaintPatcher() { DCHECK_EQ(refcount_, 0); }

[Robert Sesek, 2011/02/17 19:57:02]

This needs to be '0U' instead of just 0. I'll make this change and try it once
more.

 
   void RefPatch() {
     if (refcount_ == 0) {
@@ -1059,7 +1059,7 @@
 
 string16 AutocompleteEditViewWin::GetLabelForCommandId(
     int command_id) const {
-  DCHECK(command_id == IDS_PASTE_AND_GO);
+  DCHECK_EQ(command_id, IDS_PASTE_AND_GO);
   return l10n_util::GetStringUTF16(model_->is_paste_and_search() ?
       IDS_PASTE_AND_SEARCH : IDS_PASTE_AND_GO);
 }
@@ -2038,7 +2038,7 @@
     return;
   ScopedComPtr<ITextSelection> selection;
   const HRESULT hr = text_object_model->GetSelection(selection.Receive());
-  DCHECK(hr == S_OK);
+  DCHECK_EQ(hr, S_OK);
   long flags;
   selection->GetFlags(&flags);
   if (flags & tomSelStartActive)
@@ -2068,7 +2068,7 @@
     return;
   ScopedComPtr<ITextSelection> selection;
   const HRESULT hr = text_object_model->GetSelection(selection.Receive());
-  DCHECK(hr == S_OK);
+  DCHECK_EQ(hr, S_OK);
   selection->SetFlags(tomSelStartActive);
 }
 
@@ -2304,7 +2304,7 @@
 
 void AutocompleteEditViewWin::DrawDropHighlight(
     HDC hdc, const CRect& client_rect, const CRect& paint_clip_rect) {
-  DCHECK(drop_highlight_position_ != -1);
+  DCHECK_NE(drop_highlight_position_, -1);
 
   const int highlight_y = client_rect.top + font_y_adjustment_;
   const int highlight_x = PosFromChar(drop_highlight_position_).x - 1;