chrome/browser/app_controller_mac.mm - Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/alternate_nav_url_fetcher.cc ('k') | chrome/browser/appcache/appcache_dispatcher_host.cc » ('j') | chrome/browser/autocomplete/autocomplete_edit_view_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/app_controller_mac.mm

===================================================================

--- chrome/browser/app_controller_mac.mm (revision 75286)

+++ chrome/browser/app_controller_mac.mm (working copy)

@@ -1118,7 +1118,7 @@

// window controller.

- (void)prefsWindowClosed:(NSNotification*)notification {

NSWindow* window = [prefsController_ window];

- DCHECK([notification object] == window);

+ DCHECK_EQ([notification object], window);

NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter];

[defaultCenter removeObserver:self

name:NSWindowWillCloseNotification

@@ -1171,7 +1171,7 @@

// window controller.

- (void)aboutWindowClosed:(NSNotification*)notification {

NSWindow* window = [aboutController_ window];

- DCHECK(window == [notification object]);

+ DCHECK_EQ(window, [notification object]);

[[NSNotificationCenter defaultCenter]

removeObserver:self

name:NSWindowWillCloseNotification

@@ -1239,7 +1239,7 @@

for (ExtensionList::const_iterator cursor = applications.begin();

cursor != applications.end();

++cursor, ++position) {

- DCHECK(position == applications.GetPosition(*cursor));

+ DCHECK_EQ(position, applications.GetPosition(*cursor));

NSString* itemStr =

base::SysUTF16ToNSString(UTF8ToUTF16((*cursor)->name()));

scoped_nsobject<NSMenuItem> appItem([[NSMenuItem alloc]