Issue 6532068: Fix a bug in ImplicitWaitCommand: we must explicitly check if the ms param...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6532068: Fix a bug in ImplicitWaitCommand: we must explicitly check if the ms param... (Closed)

Created:
9 years, 10 months ago by Jason Leyba

Modified:
9 years, 7 months ago

Reviewers:
kkania, Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fix a bug in ImplicitWaitCommand: we must explicitly check if the ms param was sent as a floating point number after checking for an integer. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : Adding some files missed in previous upload #

Patch Set 3 : Reverting changes added while debugging #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -28 lines)			Patch
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -0 lines	1 comment	Download
M	chrome/test/webdriver/commands/command.h	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/commands/command.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/commands/implicit_wait_command.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/test/webdriver/commands/implicit_wait_command.cc	View	1 2	2 chunks	+28 lines, -24 lines	0 comments	Download
A	chrome/test/webdriver/commands/implicit_wait_command_unittest.cc	View	1	1 chunk	+91 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/session.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kkania

LGTM, did you see if this fixed any of the implicit wait tests? if so, ...

9 years, 10 months ago (2011-02-19 00:54:55 UTC) #2

Jason Leyba

On 2011/02/19 00:54:55, kkania wrote: > LGTM, did you see if this fixed any of ...

9 years, 10 months ago (2011-02-19 00:59:41 UTC) #3

Paweł Hajdan Jr.

9 years, 10 months ago (2011-02-19 11:49:18 UTC) #4

Drive-by with a tiny nit, no need to wait for me.

http://codereview.chromium.org/6532068/diff/10/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/6532068/diff/10/chrome/chrome_tests.gypi#newco...
chrome/chrome_tests.gypi:867:
'test/webdriver/commands/implicit_wait_command_unittest.cc',
nit: Preserve alphabetical order.

Expand Messages | Collapse Messages